Comments plugin links broken...

Found a bug? Tell us!!
Post Reply
dand
Regular
Posts: 18
Joined: Wed Sep 17, 2003 4:23 am
Contact:

Comments plugin links broken...

Post by dand »

On my blog the comments plugin in the sidebar created links that pointed to "blog/archives/##_article.html" which were always dead links. The actual archive URLs, as far is I can tell, should be "blog/archives/##_<entry-title>.html".

Changing line 128 of serendipity_plugin_comments.php from

Code: Select all

'<a class="highlight" href="/serendipity/archives/' . $row['entry_id'] . '_article.html" title="' . htmlentities($row['Subject']) . '">'
to

Code: Select all

' <a class="highlight" href="'.serendipity_archiveURL($row['entry_id'], $row['Subject']).'" title="' . htmlentities($row['Subject']) . '">'
fixes this problem.

What I can't figure out is, on Garvin's superBlog, the original "##_article.html" links are not dead. And I look inside my blog/archives/ directory and it's empty. I'm not really a web developer so I don't really get what's going on. Can someone shed some light on the issue?

Thanks.

Daniel
tomsommer
Core Developer
Posts: 240
Joined: Tue Sep 02, 2003 6:43 pm
Location: Denmark
Contact:

Post by tomsommer »

blog/archives/##_<entry-title>.html

the <entry-title> is not used for anything, only the prefixed number (ID)

I'll commit the change you suggested, since we should try and keep the URLs consistant :)
Tom Sommer (Serendipity Core Developer)
http://blog.dreamcoder.dk
Post Reply