Page 2 of 3

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jun 02, 2019 10:48 am
by thh
onli wrote:
Sat Jun 01, 2019 3:23 pm
Then it's possible it's a bug in 2.1.5 we fixed only in 2.3.
The fix went in even after the release of the 2.3-beta. :)

I've backported it now for a presumably final 2.1.6 release later on.

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jun 02, 2019 11:57 am
by onli
Ah, okay! Thank you :)

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 12:41 pm
by corcons
Hi, I've got the same errors. Here is what I've done:
1.) I've installed the auto updater
2.) I've started the updater and the update was successfully
3.) After the update was completed a page shows up with a link to finish the update
4.) When clicked this link I've got a bunch of fatal errors I'll show this below.
5.) I'm running PHP version 7.2 on my machine and as I've set the PHP version at the .htacces file to version 5.6 (AddHandler application/x-httpd-php56 .php) I could finish point 3.) and the frontend works fine to.

Question would you be able to fix this problem in a short time, because I do not like to run an old PHP version.

Errors

Code: Select all

Fatal error: Uncaught ErrorException: Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php:253 Stack trace: #0 [internal function]: errorToExceptionHandler(2, 'sizeof(): Param...', '/home/corconsc/...', 253, Array) #1 /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php(253): sizeof(NULL) #2 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_5d2d99c68ee6d3_95491941(Object(Smarty_Internal_Template)) #3 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template)) #4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled- in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php on line 253
== ERROR-REPORT (BETA/ALPHA-BUILDS) ==
Fatal Error: Uncaught ErrorException: Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php:253 Stack trace: #0 [internal function]: errorToExceptionHandler(2, 'sizeof(): Param...', '/home/corconsc/...', 253, Array) #1 /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php(253): sizeof(NULL) #2 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_5d2d99c68ee6d3_95491941(Object(Smarty_Internal_Template)) #3 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template)) #4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled- in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php on line 253.
For more details set $serendipity['production'] = 'debug' in serendipity_config_local.inc.php to receive a stack-trace.



Fatal error: Uncaught ErrorException: Fatal Error: Uncaught ErrorException: Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php:253
Stack trace:
#0 [internal function]: errorToExceptionHandler(2, 'sizeof(): Param...', '/home/corconsc/...', 253, Array)
#1 /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php(253): sizeof(NULL)
#2 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_5d2d99c68ee6d3_95491941(Object(Smarty_Internal_Template))
#3 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template))
#4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_internal_templa in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php on line 253

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 1:36 pm
by corcons
Verify Installation Integrity
Unable to compare checksums! (No checksums.inc.php in main directory)
File is there but empty
After copying he file from the downloaded version, transfered them to the main die the check ferifyed "All required files verified."

Fatal errors from plugins after update and running PHP version 7.2 (server error file)

Code: Select all

[16-Jul-2019 11:24:17 UTC] PHP Fatal error:  Uncaught ErrorException: Warning: A non-numeric value encountered in /home/corconsc/blog.corcons.com/plugins/serendipity_event_karma/serendipity_event_karma.php:2063
Stack trace:
#0 /home/corconsc/blog.corcons.com/plugins/serendipity_event_karma/serendipity_event_karma.php(2063): errorToExceptionHandler(2, 'A non-numeric v...', '/home/corconsc/...', 2063, Array)
#1 /home/corconsc/blog.corcons.com/plugins/serendipity_event_karma/serendipity_event_karma.php(1404): serendipity_event_karma->createRatingBar('29', 0, 0)
#2 /home/corconsc/blog.corcons.com/include/plugin_api.inc.php(1138): serendipity_event_karma->event_hook('entry_display', Object(serendipity_property_bag), Array, Array)
#3 /home/corconsc/blog.corcons.com/include/functions_entries.inc.php(1065): serendipity_plugin_api::hook_event('entry_display', Array, Array)
#4 /home/corconsc/blog.corcons.com/include/genpage.inc.php(129): serendipity_printEntries(Array)
#5 /home/corconsc/blog.corcons.com/include/functions_routing.inc.php(18): include('/home/corcon in /home/corconsc/blog.corcons.com/plugins/serendipity_event_karma/serendipity_event_karma.php on line 2063
[16-Jul-2019 11:28:33 UTC] PHP Fatal error:  Uncaught ErrorException: Warning: Use of undefined constant baseURL - assumed 'baseURL' (this will throw an Error in a future version of PHP) in /home/corconsc/blog.corcons.com/plugins/serendipity_plugin_wikipedia_finder/serendipity_plugin_wikipedia_finder.php:165
Stack trace:
#0 /home/corconsc/blog.corcons.com/plugins/serendipity_plugin_wikipedia_finder/serendipity_plugin_wikipedia_finder.php(165): errorToExceptionHandler(2, 'Use of undefine...', '/home/corconsc/...', 165, Array)
#1 /home/corconsc/blog.corcons.com/include/plugin_api.inc.php(933): serendipity_plugin_wikipedia_finder->generate_content('Wikipedia Finde...')
#2 /home/corconsc/blog.corcons.com/include/functions_smarty.inc.php(619): serendipity_plugin_api::generate_plugins('right')
#3 /home/corconsc/blog.corcons.com/templates_c/timeline/23/1f/59/231f593a695fb9b7511cf9c996cddcd7c1019c86_0.file.index.tpl.php(348): serendipity_smarty_printSidebar(Array, Object(Smarty_Internal_Template))
#4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysp in /home/corconsc/blog.corcons.com/plugins/serendipity_plugin_wikipedia_finder/serendipity_plugin_wikipedia_finder.php on line 165

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 2:22 pm
by corcons
If I update editing pages following warning and error:

Code: Select all

Warning: Unsupported declare 'strict_types' in /home/corconsc/blog.corcons.com/bundled-libs/voku/simple-cache/src/voku/cache/CacheAdapterAutoManager.php on line 3

Parse error: syntax error, unexpected ':', expecting ';' or '{' in /home/corconsc/blog.corcons.com/bundled-libs/voku/simple-cache/src/voku/cache/CacheAdapterAutoManager.php on line 32

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 2:55 pm
by onli
I assume this is still running PHP 5.6. In PHP 7 strict_types should be understood, so the most likely explanation is the switch to PHP 7 did not work. Can you confirm?

There seem to be multiple different errors in plugins and themes used here:

1. error points to timeline. You should talk with Don about that, btu we can also have a look when the rest is fixed.
2. error seems to be in serendipity_plugin_wikipedia_finder. And yes, line 165 uses a constant that does not exist. That I can fix now.
3. error it claims to be in serendipity_event_karma.php. Line 2063 is indeed a calculation, maybe one of those variables in really not a number? PHP 5.6 probably did not care about that. Can you edit the file and add (int) in front of the variables?

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 4:20 pm
by corcons
Yes I've put everything back to Serendipity version 2.1.5 and PHP version to 7.2 as it was before the update.
On the Karma plugin I've put the (int) and the error is gone. If I run PHP 5.6 the error stays.
This are the actual errors / warnings now on Serendipity version 2.1.5 and PHP version to 7.2:

Code: Select all

[16-Jul-2019 14:10:26 UTC] PHP Warning:  Use of undefined constant Y - assumed 'Y' (this will throw an Error in a future version of PHP) in /home/corconsc/blog.corcons.com/templates/timeline/config.inc.php on line 211
[16-Jul-2019 14:10:26 UTC] PHP Warning:  Use of undefined constant baseURL - assumed 'baseURL' (this will throw an Error in a future version of PHP) in /home/corconsc/blog.corcons.com/plugins/serendipity_plugin_wikipedia_finder/serendipity_plugin_wikipedia_finder.php on line 165
But what is happen if I upgrade to Serendipity Version 2.3-beta1 running with PHP 7.2 and there is no frontend and neither a backend sow up in the browser: JUST THE BUNCH OF ERRORS????????? But as a miracle, if I set PHP to 5.6 the new version function. I guess this is not that is what we want.

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 4:20 pm
by corcons
Yes I've put everything back to Serendipity version 2.1.5 and PHP version to 7.2 as it was before the update.
On the Karma plugin I've put the (int) and the error is gone. If I run PHP 5.6 the error stays.
This are the actual errors / warnings now on Serendipity version 2.1.5 and PHP version to 7.2:

Code: Select all

[16-Jul-2019 14:10:26 UTC] PHP Warning:  Use of undefined constant Y - assumed 'Y' (this will throw an Error in a future version of PHP) in /home/corconsc/blog.corcons.com/templates/timeline/config.inc.php on line 211
[16-Jul-2019 14:10:26 UTC] PHP Warning:  Use of undefined constant baseURL - assumed 'baseURL' (this will throw an Error in a future version of PHP) in /home/corconsc/blog.corcons.com/plugins/serendipity_plugin_wikipedia_finder/serendipity_plugin_wikipedia_finder.php on line 165
But what is happen if I upgrade to Serendipity Version 2.3-beta1 running with PHP 7.2 and there is no frontend and neither a backend sow up in the browser: JUST THE BUNCH OF ERRORS????????? But as a miracle, if I set PHP to 5.6 the new version function. I guess this is not that is what we want.

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Tue Jul 16, 2019 7:54 pm
by corcons
Ok, I've re-upgraded to version 2.3 again but I've leave the PHP version on 5.6. After Updating I set the PHP version to 7.2 and so far it looks OK.

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jul 21, 2019 1:27 pm
by thh
onli wrote:
Tue Jul 16, 2019 2:55 pm
2. error seems to be in serendipity_plugin_wikipedia_finder. And yes, line 165 uses a constant that does not exist. That I can fix now.
3. error it claims to be in serendipity_event_karma.php. Line 2063 is indeed a calculation, maybe one of those variables in really not a number? PHP 5.6 probably did not care about that. Can you edit the file and add (int) in front of the variables?
Hey onli, can you follow up to that and commit the necessary fixes, or should I add an issue to track that?

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jul 21, 2019 2:35 pm
by onli
Hi, I pushed an update for the wikipedia_finder (1.5.1), but for serendipity_event_karma I'd need more feedback.

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jul 21, 2019 6:57 pm
by thh
onli wrote:
Sun Jul 21, 2019 2:35 pm
Hi, I pushed an update for the wikipedia_finder (1.5.1), but for serendipity_event_karma I'd need more feedback.
Looks like the "(int)" fixed it?
corcons wrote:
Tue Jul 16, 2019 4:20 pm
Yes I've put everything back to Serendipity version 2.1.5 and PHP version to 7.2 as it was before the update.
On the Karma plugin I've put the (int) and the error is gone. If I run PHP 5.6 the error stays.

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jul 21, 2019 7:36 pm
by corcons
Hi Onli,
so far I can tell you, most of the plugins, except the basic needed do not run with PHP 7 or higher.
But I like to stay focused at the main issue and I'll do this chronological now. When I updated from Verision 2.1.5 to 2.3-beta 1 I've used PHP version 7.2 and after failing with
1.) I've installed the auto updater
2.) I've started the updater
3.) After the update was completed a page shows up with a link to finish the update.
4.) When clicked this link I've got a bunch of fatal errors.

Code: Select all

Fatal error: Uncaught ErrorException: Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php:253 Stack trace: #0 [internal function]: errorToExceptionHandler(2, 'sizeof(): Param...', '/home/corconsc/...', 253, Array) #1 /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php(253): sizeof(NULL) #2 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_5d2d99c68ee6d3_95491941(Object(Smarty_Internal_Template)) #3 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template)) #4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled- in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php on line 253
== ERROR-REPORT (BETA/ALPHA-BUILDS) ==
Fatal Error: Uncaught ErrorException: Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php:253 Stack trace: #0 [internal function]: errorToExceptionHandler(2, 'sizeof(): Param...', '/home/corconsc/...', 253, Array) #1 /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php(253): sizeof(NULL) #2 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_5d2d99c68ee6d3_95491941(Object(Smarty_Internal_Template)) #3 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template)) #4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_internal_template.php(216): Smarty_Template_Compiled- in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php on line 253.
For more details set $serendipity['production'] = 'debug' in serendipity_config_local.inc.php to receive a stack-trace.



Fatal error: Uncaught ErrorException: Fatal Error: Uncaught ErrorException: Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php:253
Stack trace:
#0 [internal function]: errorToExceptionHandler(2, 'sizeof(): Param...', '/home/corconsc/...', 253, Array)
#1 /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php(253): sizeof(NULL)
#2 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_resource_base.php(123): content_5d2d99c68ee6d3_95491941(Object(Smarty_Internal_Template))
#3 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_template_compiled.php(114): Smarty_Template_Resource_Base->getRenderedTemplateCode(Object(Smarty_Internal_Template))
#4 /home/corconsc/blog.corcons.com/bundled-libs/Smarty/libs/sysplugins/smarty_internal_templa in /home/corconsc/blog.corcons.com/templates_c/timeline/b8/f9/3f/b8f93f2c5be720c95c25162d4483180bacbd406e_0.file.upgrader.inc.tpl.php on line 253
5.) When I updated I was using PHP 7.2
6.) I've made new fresh installation uploaded all files to the server.
7.) I started the installation as described for fresh installation
8.) Same as on point 4.) described
9.) I've reinstalled my version 2.1.5
10.) I've set my PHP version to 5.6 and run the auto-upgrade again.
11.) After the upgrade I've set the my PHP version to 7.2 and so far then it looks OK.
12.) Now I've changed some entries and everything was working fine.
13.) Now I've tried to put a new entry and saved the entry just with only the "Title" was filled in. After I pressed the save button I got the errors below. I pressed the save button some more without leaving the page.

Code: Select all

[21-Jul-2019 14:15:17 UTC] PHP Fatal error:  Uncaught ErrorException: Warning: mysqli_query(): Empty query in /home/corconsc/blog.corcons.com/de/include/db/mysqli.inc.php:68
Stack trace:
#0 [internal function]: errorToExceptionHandler(2, 'mysqli_query():...', '/home/corconsc/...', 68, Array)
#1 /home/corconsc/blog.corcons.com/de/include/db/mysqli.inc.php(68): mysqli_query(Object(mysqli), '')
#2 /home/corconsc/blog.corcons.com/de/plugins/serendipity_event_metadesc/serendipity_event_metadesc.php(251): serendipity_db_query(NULL)
#3 /home/corconsc/blog.corcons.com/de/include/plugin_api.inc.php(1138): serendipity_event_metadesc->event_hook('backend_publish', Object(serendipity_property_bag), Array, 1)
#4 /home/corconsc/blog.corcons.com/de/include/functions_entries.inc.php(1468): serendipity_plugin_api::hook_event('backend_publish', Array, 1)
#5 /home/corconsc/blog.corcons.com/de/include/functions_config.inc.php(832): serendipity_updertEntry(Array)
#6 /home/corconsc/blog.corcons.com/de/serendipity_admin.php(52): serendipity_iframe(Array, 'save')
#7 {main}
  t in /home/corconsc/blog.corcons.com/de/include/db/mysqli.inc.php on line 68
[21-Jul-2019 14:17:39 UTC] PHP Fatal error:  Uncaught ErrorException: Warning: mysqli_query(): Empty query in /home/corconsc/blog.corcons.com/de/include/db/mysqli.inc.php:68
Stack trace:
#0 [internal function]: errorToExceptionHandler(2, 'mysqli_query():...', '/home/corconsc/...', 68, Array)
#1 /home/corconsc/blog.corcons.com/de/include/db/mysqli.inc.php(68): mysqli_query(Object(mysqli), '')
#2 /home/corconsc/blog.corcons.com/de/plugins/serendipity_event_metadesc/serendipity_event_metadesc.php(251): serendipity_db_query(NULL)
#3 /home/corconsc/blog.corcons.com/de/include/plugin_api.inc.php(1138): serendipity_event_metadesc->event_hook('backend_save', Object(serendipity_property_bag), Array, 0)
#4 /home/corconsc/blog.corcons.com/de/include/functions_entries.inc.php(1470): serendipity_plugin_api::hook_event('backend_save', Array, 0)
#5 /home/corconsc/blog.corcons.com/de/include/functions_config.inc.php(832): serendipity_updertEntry(Array)
#6 /home/corconsc/blog.corcons.com/de/serendipity_admin.php(52): serendipity_iframe(Array, 'save')
#7 {main}
  thrown in /home/corconsc/blog.corcons.com/de/include/db/mysqli.inc.php on line 68
14.) Then I going to the "Edit Entries" page to see what happen. At each time I pressed the save button it was a new page created. In other words 10 for just saving and updating one page. and on all entries was the "META-Description:, META-Keywords:, HTML page title element" deleted.
15.) I made some more entries and soonest as I filled in the mentioned 3 fields the entries was done fine.
15.) Now I checked the thrown errors which come to the file "include/db/mysqli.inc.php"at line 68
16.) I changed on line 61 "$expectError = false" to "$expectError = true" and all the edit problems are gone.

i hope this will help you to find the problems. :wink:

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jul 21, 2019 8:04 pm
by onli
Okay. I now pushed also a fix for the karma plugin.

corcons, thanks for the writeup. I hope that now that the plugins are fixed the experience when upgrading will be a bit better. The multiple entries being saved when editing can happen when a plugin throws an error during saving, so that might be fixed as well. The mysql aspect of your solution with $expectError = false I won't touch for now. It looks like there is an error in serendipity_event_metadesc.php, which this change in mysql now manages to supress, but I'm not very familiar with that plugin. thh uses it though I think :)

Re: "Uncaught Error" when updating from 2.15 to 2.3-beta1

Posted: Sun Jul 21, 2019 9:54 pm
by thh
onli wrote:
Sun Jul 21, 2019 8:04 pm
It looks like there is an error in serendipity_event_metadesc.php, which this change in mysql now manages to supress, but I'm not very familiar with that plugin. thh uses it though I think :)
Yes. Looks like a regression from https://github.com/s9y/additional_plugins/pull/99.

Before, the last branch of the if conditional was erroneusly executed when the property was present in the database and wasn't changed. Now q isn't set in this case. That is correct, but we mustn't execute an empty serendipity_db_query ...

https://github.com/s9y/additional_plugins/pull/101 should fix that.