Recent beta1 (git pull) gives feed error

Found a bug? Tell us!!
Post Reply
User avatar
Lux
Regular
Posts: 750
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Recent beta1 (git pull) gives feed error

Post by Lux » Wed Jul 27, 2016 7:19 am

Hi!

I updated my blog to the recent beta via "git pull" and now I get a feed error.

https://www.deimeke.net/dirk/blog/index ... index.rss2

Code: Select all

XML Parsing Error: syntax error
Location: https://www.deimeke.net/dirk/blog/index.php?/feeds/index.rss2
Line Number 1, Column 1:Invalid RSS version specified or RSS-template file not found
^
http://www.feedvalidator.org/check.cgi? ... index.rss2

Cheers

Dirk

User avatar
onli
Regular
Posts: 2142
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Recent beta1 (git pull) gives feed error

Post by onli » Wed Jul 27, 2016 9:34 am

Confirmed. Related change: https://github.com/s9y/Serendipity/comm ... e05b843419. I'm looking into it.

User avatar
onli
Regular
Posts: 2142
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Recent beta1 (git pull) gives feed error

Post by onli » Wed Jul 27, 2016 9:59 am

Okay. The problem here is that this commit changed the logic more than I was aware. Until now, regardless of the engine chosen, templates/default still was queried for files – that is why 2k11 could get away with not having the feed templates despite being the default theme. The easy fix is moving the feed templates (and the banner image) into 2k11.

User avatar
Lux
Regular
Posts: 750
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Recent beta1 (git pull) gives feed error

Post by Lux » Wed Jul 27, 2016 10:02 am

onli wrote:Okay. The problem here is that this commit changed the logic more than I was aware. Until now, regardless of the engine chosen, templates/default still was queried for files – that is why 2k11 could get away with not having the feed templates despite being the default theme. The easy fix is moving the feed templates (and the banner image) into 2k11.
Can you please tell me the files names?

User avatar
onli
Regular
Posts: 2142
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Recent beta1 (git pull) gives feed error

Post by onli » Wed Jul 27, 2016 10:39 am

Sure: templates/default/feed*tpl

I already fixed it in master: https://github.com/s9y/Serendipity/comm ... e70536cc3c. It would be great if you could test it.

User avatar
Lux
Regular
Posts: 750
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Recent beta1 (git pull) gives feed error

Post by Lux » Wed Jul 27, 2016 11:15 am

onli wrote:Sure: templates/default/feed*tpl

I already fixed it in master: https://github.com/s9y/Serendipity/comm ... e70536cc3c. It would be great if you could test it.
Works again. Thank you!

Cheers

Dirk

User avatar
onli
Regular
Posts: 2142
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Recent beta1 (git pull) gives feed error

Post by onli » Wed Jul 27, 2016 11:18 am

Well, I broke it ;) Thanks for reporting!

Post Reply