[2.0.0beta2] serendipity_event_typesetbuttons

Found a bug? Tell us!!
User avatar
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

[2.0.0beta2] serendipity_event_typesetbuttons

Post by Lux » Tue Apr 15, 2014 11:48 am

Hi!

Please have a look at the serendipity_event_typesetbuttons-plugin, the buttons do not seem to work anymore:

I defined

Code: Select all

code@<code>@</code>|
pre@<pre>@</pre>|
bash@[geshi lang=bash]@[/geshi]|
perl@[geshi lang=perl]@[/geshi]|
sql@[geshi lang=sql]@[/geshi]|
li@<li>@</li>
Cheers

Dirk

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by garvinhicking » Tue Apr 15, 2014 1:22 pm

Hi!

Thanks. This can very well be as the WYSIWYG integration has been worked over. Didn't have the time to check yet, but I also added this as a github issue so that we keep it as blocking for the RC: https://github.com/s9y/Serendipity/issues/114

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by Lux » Tue Apr 15, 2014 1:36 pm

garvinhicking wrote:Thanks. This can very well be as the WYSIWYG integration has been worked over. Didn't have the time to check yet, but I also added this as a github issue so that we keep it as blocking for the RC: https://github.com/s9y/Serendipity/issues/114
Thank you Garvin. Where do you like bug reports more? GitHub or forum?

Cheers

Dirk

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by garvinhicking » Tue Apr 15, 2014 1:51 pm

Hi!

I personally try to cover things in the boards, but when I see issues that I myself cannot deal with, it's good to have them in a list/tracker. That shouldn't be your problem though - I'd copy threads from here to the issue tracker. Ideally I believe the forum receives more specific attention. What do others think?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by Lux » Tue Apr 15, 2014 2:02 pm

garvinhicking wrote:I personally try to cover things in the boards, but when I see issues that I myself cannot deal with, it's good to have them in a list/tracker. That shouldn't be your problem though - I'd copy threads from here to the issue tracker. Ideally I believe the forum receives more specific attention. What do others think?
I think issues should be visible in both worlds and link to each other.

Cheers

Dirk

User avatar
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by yellowled » Tue Apr 15, 2014 2:33 pm

garvinhicking wrote:What do others think?
I think it's two worlds, really.

As a developer, I prefer to file bugs I spot myself directly in the GitHub issue tracker, just because it saves time. I can imagine a lot of users would be more comfortable reporting bugs in the forums, though. I'm happy to “translate” any bug reported here to GitHub.

However, anything that might require a discussion should be reported in the forums.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

mattsches
Regular
Posts: 440
Joined: Sat Nov 05, 2005 9:35 pm
Location: Wiesbaden, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by mattsches » Wed Apr 16, 2014 2:57 pm

I can take a look at this issue. I think I already found out what the problem is. I will also try to clean up this plugin a little bit.

mattsches
Regular
Posts: 440
Joined: Sat Nov 05, 2005 9:35 pm
Location: Wiesbaden, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by mattsches » Sat Apr 19, 2014 12:32 am

Guys, I spend the greater part of this day coding, refactoring and unit testing - and found it to be very enjoyable! Maybe that's because I've been dealing with a lot of DevOps stuff at work and hardly wrote any PHP code lately 8)

Anyway, I created an almost completely reworked version of the typesetbuttons plugin that should work with both versions < 2.0 and the current beta. If you want to test it, make sure to install the very latest version from GitHub! I chatted with Matthias (yellowled), and he had to make some changes to the backend editor so that everything works as expected.

If you use this plugin (Dirk, I'm looking at you), please be so kind and test if everything works ok (on a test installation, of course). If possible, test it with s9y 1.7.* or older, too. I wrote unit tests first to ensure that nothing breaks backwards compatibility, but the original code was so ... peculiar that I can't guarantee anything :roll:

I uploaded version 0.20 of serendipity_event_typesetbuttons to my Dropbox and will leave it there for a while.

Thanks,
mattsches

User avatar
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by Lux » Sat Apr 19, 2014 12:18 pm

Hi!

Does not work for me.

I get a "<undefined></undefined>" for every self-defined button.

No information under the info item.

Cheers

Dirk

mattsches
Regular
Posts: 440
Joined: Sat Nov 05, 2005 9:35 pm
Location: Wiesbaden, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by mattsches » Sun Apr 20, 2014 11:12 am

I suppose you tested against the 2.0 branch? Did you pull in the latest changes from GitHub? This commit is crucial, otherwise it won't work.

Is there any output in the Firebug console/Chrome dev tools console? This might be a JS issue ...

Matthias

User avatar
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by Lux » Mon Apr 21, 2014 9:41 am

mattsches wrote:I suppose you tested against the 2.0 branch? Did you pull in the latest changes from GitHub? This commit is crucial, otherwise it won't work.
I downloaded the tar.gz-file you offered.
mattsches wrote:Is there any output in the Firebug console/Chrome dev tools console? This might be a JS issue ...
I don't use any of those tools.

Now I cloned the additional_plugins-repository and it does not work either. This time no output is generated.

Cheers

Dirk

User avatar
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by yellowled » Mon Apr 21, 2014 10:35 am

Lux wrote:I downloaded the tar.gz-file you offered.
That will only work with a recent Git checkout of the 2.0 branch of the s9y core since it relies on things included there since beta2.
Lux wrote:I don't use any of those tools.
In Chrome, it's very easy. Load page, and then I guess it's [Alt] + [Crtl] + J (I only know the shortcut on OS X, which does't have Ctrl). Whatever output is in that window (that's the Console) could be relevant. Some of it will only appear after you interact (e.g. by clicking buttons).

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
u1amo01
Regular
Posts: 273
Joined: Fri Sep 28, 2007 3:55 pm
Location: Kurpfalz, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by u1amo01 » Mon Apr 21, 2014 8:23 pm

Hi, I've installed the latest s9y-version from github, the plugin from Matthias dropox and Chromium.

With Debian Linux it's shift ctrl J

And the output of Console is
"Failed to load resource: the server responded with a status of 404 (Not Found) "

Not very helpful, I fear.

User avatar
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by yellowled » Mon Apr 21, 2014 8:40 pm

u1amo01 wrote:"Failed to load resource: the server responded with a status of 404 (Not Found) "

Not very helpful, I fear.
Not without the name of the resource it failed to load, which should be displayed at the end of that line in the console.

If it's jquery.min.map, that doesn't help much, either. (That's a technical error, which should be fixed in the browser and should not block the rest of the JS from being executed.)

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
u1amo01
Regular
Posts: 273
Joined: Fri Sep 28, 2007 3:55 pm
Location: Kurpfalz, Germany
Contact:

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Post by u1amo01 » Mon Apr 21, 2014 9:03 pm

Failed to load resource: the server responded with a status of 404 (Not Found) http://u1amo01.de/blog/serendipity.js&v=1397649512

No idea about 1397649512. But when I look into the source of my blog, there's this number again in the head:
" <link rel="stylesheet" type="text/css" media="screen, projection" href="http://u1amo01.de/blog/serendipity.css?v=1397649512">"

In the index.tpl of my theme I have the following code:

Code: Select all

    <link rel="stylesheet" type="text/css" media="screen, projection" href="{$head_link_stylesheet}">

Post Reply