event_entryproperties fullfilled with login data in chrome

Found a bug? Tell us!!
Post Reply
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

event_entryproperties fullfilled with login data in chrome

Post by Timbalu »

Hi everybody

Simply I never really use the automatic log-in function which saves the data.
But now I did, since a few weeks, and was really surprised, to find the plain login-name and the -password being asterixed set in the backends entryform part of entryproperties in the freetags tag input field and the latter in the properties password input field.

This does happen with Chrome only, FF does not do this!

Is that a funny configuration (meaning strange plugin order or so) or is that a code and/or browser issue?
Please set me on the right track! Does anybody has the same appear?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: event_entryproperties fullfilled with login data in chro

Post by garvinhicking »

Hi!

Yes, because the field is called "password" some browser try to be smarty and autofill it.

I think we have patched this already to include autocomplete="off" in that field, haven't we? Then I would wonder why it doesn't work....
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: event_entryproperties fullfilled with login data in chro

Post by Timbalu »

It's a 1.7.2...

Isn't that need to be "namespaced" somehow...?
I think this is bad to happen there, since you could miss to purge them before submitting a new entry.

When was that fixed?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: event_entryproperties fullfilled with login data in chro

Post by garvinhicking »

I don't remember. Can you check if autocomplete="off" or sth like that is contained in the input field for the passwort?
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: event_entryproperties fullfilled with login data in chro

Post by Timbalu »

YES, element html copy:
<input autocomplete="off" class="input_textbox" type="password" name="serendipity[properties][entrypassword]" value="">

The value field is shown asterixed.

What makes me wonder why this happens, since this input has a (unique?) name....


In addition the input field where the name is displayed.
<input type="text" name="serendipity[properties][freetag_tagList]" id="properties_freetag_tagList" class="wickEnabled input_textbox" value="" style="width: 100%">
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: event_entryproperties fullfilled with login data in chro

Post by garvinhicking »

Hi!

I figure then it's because of the type='password' thing. If autocomplete is there, I don't really know how to prevent chrome from autofilling.

(The name is filled I believe simply becuause it's the next username field next to a password...)
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: event_entryproperties fullfilled with login data in chro

Post by Timbalu »

Well then... maybe our "template director" (YL) has an idea on how to get rid of it... :wink:
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: event_entryproperties fullfilled with login data in chro

Post by yellowled »

Sure. Don't use browser autofill. Ever. :mrgreen:

YL
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: event_entryproperties fullfilled with login data in chro

Post by Timbalu »

I appreciate Mr. Green, ... but this is not a good answer for John Doe, isn't it?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: event_entryproperties fullfilled with login data in chro

Post by yellowled »

Actually, it is very good advice for John Doe in my book. :)

Anyway, I don't see an option. If the autocomplete attribute fails, the only option would be to not use the password type here, which very likely is not what we want.

Also, if it only fails in Chrome, it's very likely a browser bug. You could report it to the Chromium project, but fixing it in our markup sounds not very reasonable to me.

YL
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: event_entryproperties fullfilled with login data in chro

Post by Timbalu »

yellowled wrote:Actually, it is very good advice for John Doe in my book. :)
Oho, are you working on a "S9y for Dummies" equivalent to that hadley bestseller...? :mrgreen:

Could you give a hint on where to do this in detail? I did not see a config option for this on my first quick view...

Edit: A found it, some last update must have reset my extended option view. It is in Options - extended view - passwords and formulas...
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: event_entryproperties fullfilled with login data in chro

Post by yellowled »

http://www.chromium.org/for-testers/bug ... guidelines

Although I'm not entirely sure as to how this might develop once Chrome switches to the Blink engine … :?

YL
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: event_entryproperties fullfilled with login data in chro

Post by Timbalu »

I dropped my edit the same time you dropped you post I assume... Thanks for the hint.

I played with it for a while now and it seems the shown fullfilled values are my piwik ones... not the Serendipity login - which was quite equal though, that is why I did not notice.
Chrome had a forbidden rule for http://domain.ext/serendipity/serendipity_admin.php in the management screen for passwords, but since this didn't work obviously, I purged that. Now I wanted to put that in again, but I don't know how to do this, since it just links to a help page not being helpful on that specific topic.... Maybe I need to reset them all to make that work again... Anyone has experiences with that?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Post Reply