[closed] sync file license truncation

[Timbalu]

Garvin,

I just noticed the fetched sync package_event_<lang>.xml file is announcing

Code: Select all

<license>GPL</license>

but in the Plugin it has

Code: Select all

$propbag->add('copyright',     'GPL & LGPL License');

Is that a problem (to solve)? I assume it is because of the "&" and it would be easy to fix this inside the plugins propbag, but maybe you could even better generate an allowance to this in the sync script(?).

[garvinhicking]

Hi!

I'm not sure, maybe you can check out the emerge_spartacus.php script which generates this. I assume this can be becuase of the "&", yes...

However "GPL & LGPL" is actually not possible. Either it's GPL OR LGPL, I think it cannot be both because one infects the other.

Regards,
Garvin

[Timbalu]

Ok, it is utf8_encode and htmlspecialchars. I will not change this.

The other is a perspective kind of view.
In case of ckeditor, for example, I could choose between 3 licenses and in case of kcfinder these were two, So I took GPL & LGPL, which they had both, in meaning: "take one of those which suits you best". Isn't that the better meaning?

[garvinhicking]

Hi!

In that case you need to write "GPL OR LGPL", but not "&" (and).

HTH,
Garvin