[1.7] Comment notification does not contain valid links

[Lux]

Hi,

with 1.7 the links send out with comment notifications are lacking the BaseURL.

Example:

Code: Select all

Folgende Möglichkeiten stehen zur Verfügung:
  Hinweis: Dieses Trackback wird ohne Bewilligung nicht dargestellt.
   Eintrag ansehen -- index.php?/archives/156-Folge-34-Bewertung-eines-Arbeitsplatzes.html
   Trackback löschen -- index.php?/delete/trackback_token_e8f7601f1384948cb7cd7e584a40fc27/2779/156-Folge-34-Bewertung-eines-Arbeitsplatzes.html
   Trackback bewilligen -- index.php?/approve/trackback_token_e8f7601f1384948cb7cd7e584a40fc27/2779/156-Folge-34-Bewertung-eines-Arbeitsplatzes.html
   Kommentar löschen und als Spam markieren: index.php?/plugin/learnAction&action=delete&category=spam&id=2779&entry_id=156
   Kommentar bewilligen und als valid markieren: index.php?/plugin/learnAction&action=approve&category=ham&id=2779&entry_id=156

Cheers

Dirk

BTW: Shall we post issues to the Github bug tracker?

[yellowled]

with 1.7 the links send out with comment notifications are lacking the BaseURL.

Again, is this a blog affected by the base url bug? Did you set the base url in config?

BTW: Shall we post issues to the Github bug tracker?

Since we haven't really decided on a general policy as to how and if to use GitHub Issues, it will probably be quicker to post it here.

YL

[Lux]

with 1.7 the links send out with comment notifications are lacking the BaseURL.

Again, is this a blog affected by the base url bug? Did you set the base url in config?

No, I did not set anything (yet).

This is only a reminder to release a patch.

BTW: Shall we post issues to the Github bug tracker?

Since we haven't really decided on a general policy as to how and if to use GitHub Issues, it will probably be quicker to post it here.

Ok!

Dirk

[Timbalu]

Again! Leaving baseURL empty is not an option, ever!
And if you don't get hit by any errors you have a lucky constellation.

The question remains, why this missing baseURL issue happens to some user only!

[Lux]

Again! Leaving baseURL empty is not an option, ever!
And if you don't get hit by any errors you have a lucky constellation.

The question remains, why this missing baseURL issue happens to some user only!

baseURL is set in my blogs.
DefaultBaseURL does not exist in config.
Before the update, the "Konfiguration/URL zum Blog" was set with the Admininterface, after Updating it was blank.
Now, DefaultBaseURL is set again.

Code: Select all

mysql> select * from serendipity_config where name like '%baseurl%';
+--------------------+----------------------+----------+
| name               | value                | authorid |
+--------------------+----------------------+----------+
| baseURL            | http://deimhart.net/ |        0 |
| autodetect_baseURL | false                |        0 |
| defaultBaseURL     | http://deimhart.net/ |        0 |
+--------------------+----------------------+----------+
3 rows in set (0.00 sec)

The same applies to all (!) of the blogs I maintain.

Cheers

Dirk

[onli]

Again! Leaving baseURL empty is not an option, ever!

Luckily not true :-) Leaving it empty is perfectly fine if the auto-detection is enabled and working.
Regards

[Timbalu]

Good to know, but autodetection is off by default, isn't it?

[onli]

Yes, seems that way.