[Solved] Comments in 1.7-RC3, no answer link

[Lux]

OK
So what is inside? Could you list two or three of them, if that isn't secure user data?

Code: Select all

# ls cache_?/*
cache_0/cache_00:
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_0b3499f2e6f9ef389a61612687e36df8
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_0bb6b5e52fcb2860ba2b15baab806814
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_2f770536b7019e0c7a8cc980e4057c72
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_383fd1eb7d03fd65ac189aa5a68a2760
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_52ab6192160155dc85a618e9319416a3
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_e6dbabb2e1f2126416b727da4efb20b1

...

cache_f/cache_ff:
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_2ab2a60334be54a304b7c8cbd06599c4
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_7f4e06763dbc0a3edffbb25a225d0dac
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_b7c60b69b74d7c8871676df54a4a67ad
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_c8b474e82166b8a9e7a890549a889770
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_d22eb0541811f99b83ebfe852ee236fe
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_d35a9ba0a3357add7ad3e67b972ff471
cache_2ada3ca1ef7b36d9f1a856c7b012fef5_e37792a922848455392d98d9f9d497aa

Code: Select all

# cat cache_a/cache_af/cache_2ada3ca1ef7b36d9f1a856c7b012fef5_0243db391c50c760934a5bcb736484c8 
                      3715356995IBM - OS/2 Warp - OS/2 Withdrawal from Marketing and Change in Support

# cat cache_d/cache_d5/cache_2ada3ca1ef7b36d9f1a856c7b012fef5_447c1d819532470f427483b5c2ad32a6 
                               0

Cheers

Dirk

[Timbalu]

Ok, thank you, that shows they are most possible gravatar cache files too.
So then the clearCompiledTemplate() needs to clear the template name only.

... I have got a solution and just need someone to test this... since I dont have a bunch of other plugin template files residing in t_c...

[Lux]

Ok, thank you, that shows they are most possible gravatar cache files too.

Welcome. Maybe, we should spend a minute in thinking how it would be possible to speed up gravatar lookups.

Two of my blogs have a great amount of comments.

So then the clearCompiledTemplate() needs to clear the template name only.
... I have got a solution and just need someone to test this... since I dont have a bunch of other plugin template files residing in t_c...

I can test, but not with deimhart.net, maybe dirk.deimeke.net is an option.

Cheers

Dirk

[Timbalu]

Thank you for offering...
I still need to think on how we could manage a test setup, while this will need to be included to Serendipity somehow (else you would need to install dashboard poc and the dev autoupdate plugins and wait for the 1.7 release to push an automated update).

I am afraid a minute won't help about speeding up gravatar ...

[Timbalu]

Well, no, an easy way to test this, is to temporary add

Code: Select all

if($_GET['test_smarty'] == 'true') {
    if($serendipity['smarty']->clearCompiledTemplate(null, $serendipity['template'])) {
        echo 'tc cleared!';
    } else { echo 'tc error'; }
}

to your templates config.inc file and test via url with /?test_smarty=true
Then you should have a look inside templates_c, if only the template dir (or the template files) got recompiled.
Attend: This is 1.7 only.

[Lux]

Attend: This is 1.7 only.

I have 1.7 RC3 on my private blog and the dashboard plugin is installed as well. If you need autoupdate, I can do that too.

Whatever it takes ...

Cheers

Dirk

[Lux]

I am afraid a minute won't help about speeding up gravatar ...

One easy way would be only to fetch avatars when showing comments ... not when showing the frontpage.

Cheers

Dirk

[Timbalu]

Attend: This is 1.7 only.

I have 1.7 RC3 on my private blog and the dashboard plugin is installed as well. If you need autoupdate, I can do that too.

Whatever it takes ...

Try with my pasted temporary code. The attend note was only for others watching this thread without having a 1.7 RC installed.

One easy way would be only to fetch avatars when showing comments ... not when showing the frontpage.

This is one of the more complicated plugins... may be something to give Grischa a hint, as this was his playground AFAIR.

[Lux]

Try with my pasted temporary code. The attend note was only for others watching this thread without having a 1.7 RC installed.

It works!

Cheers

Dirk

[Timbalu]

Great! Thanks for testing.
And that means it didn't touch your gravatar dirs /cache_* and /serendipity_event_avatar and also the other files, right?

[Lux]

Great! Thanks for testing.
And that means it didn't touch your gravatar dirs /cache_* and /serendipity_event_avatar and also the other files, right?

Correct!

Cheers

Dirk