Comments RSS feed not working since version 1.6.1

Found a bug? Tell us!!
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by garvinhicking »

Hi!

The bugs to rss.php where those:

https://github.com/s9y/Serendipity/comm ... be51c6c3a9
https://github.com/s9y/Serendipity/comm ... 00fc38a31d

However those only affect the "comment" RSS feed, not the main feed...so I'm wondering how this could generally break your feed...

If no APC/Bytecode Cache is in place, PHP and Apache would never react differently on a file if only the timestamp or inode changes. The browser's cache is maintained by the HTTP client through HTTP-Headers, and the timestamp that this uses is the one of the most recent entry; it is unrelated to the timestamp of rss.php. There's nothing in the PHP code of s9y that would inspect the timestamp of rss.php, actually.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by Lux »

garvinhicking wrote:The bugs to rss.php where those:
https://github.com/s9y/Serendipity/comm ... be51c6c3a9
https://github.com/s9y/Serendipity/comm ... 00fc38a31d
However those only affect the "comment" RSS feed, not the main feed...so I'm wondering how this could generally break your feed...
Now it begins to be Voodoo ...

I replaced rss.php with the recent one from GitHub. I tried to access the feed and I got the same errors. Most probably because of my browser cache.

Afterwards I copied the rss.php from version 1.6.1 and it worked ...
garvinhicking wrote:If no APC/Bytecode Cache is in place, PHP and Apache would never react differently on a file if only the timestamp or inode changes. The browser's cache is maintained by the HTTP client through HTTP-Headers, and the timestamp that this uses is the one of the most recent entry; it is unrelated to the timestamp of rss.php. There's nothing in the PHP code of s9y that would inspect the timestamp of rss.php, actually.
I have no cache activated in Apache and did not change caching settings in PHP, I use the standard settings in Debian.

... clueless ...

Cheers

Dirk
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by garvinhicking »

Hi!

You should really use wget to bypass any possible client-side caching.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by Lux »

garvinhicking wrote:You should really use wget to bypass any possible client-side caching.
To make it more complicated. 90% of the day I am behind a caching proxy.

BTW: The recent version from GitHub does not work properly (tested without caching with Firefox):
http://www.deimeke.net/testblog/index.p ... index.rss2

Code: Select all

XML Parsing Error: no element found
Location: http://www.deimeke.net/testblog/index.php?/feeds/index.rss2
Line Number 1, Column 1:
Cheers

Dirk
onli
Regular
Posts: 2830
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by onli »

In chrome, there is a 500-error shown when accessing that link. Something in the logs?
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by Lux »

onli wrote:In chrome, there is a 500-error shown when accessing that link. Something in the logs?

Code: Select all

[Fri Aug 10 06:26:25 2012] [error] [client 92.201.117.159] PHP Fatal error:  Call to undefined method Smarty::assignByRef() in /srv/www/deimeke.net/testblog/rss.php on line 253, referer: http://board.s9y.org/viewtopic.php?f=3&t=18847&start=15
[Fri Aug 10 06:26:29 2012] [error] [client 92.201.117.159] PHP Fatal error:  Call to undefined method Smarty::assignByRef() in /srv/www/deimeke.net/testblog/rss.php on line 253
[Fri Aug 10 06:26:44 2012] [error] [client 92.201.117.159] PHP Fatal error:  Call to undefined method Smarty::assignByRef() in /srv/www/deimeke.net/testblog/rss.php on line 253, referer: http://board.s9y.org/viewtopic.php?f=3&t=18847&start=15
Cheers

Dirk
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by garvinhicking »

Hi!

This sounds as if you used a rss.php from the 1.7 branch...sorry. Seems rss of 1.7 is not compatible with 1.6 due to the new smarty calls.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Lux
Regular
Posts: 764
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: Comments RSS feed not working since version 1.6.1

Post by Lux »

garvinhicking wrote: This sounds as if you used a rss.php from the 1.7 branch...sorry. Seems rss of 1.7 is not compatible with 1.6 due to the new smarty calls.
Thx, this is what I ment with "recent version from GitHub". :-)

Cheers

Dirk
Post Reply