remoterss plugin doesn't escape chars in links

Found a bug? Tell us!!
Post Reply
hanno
Regular
Posts: 72
Joined: Fri May 20, 2005 8:04 am
Contact:

remoterss plugin doesn't escape chars in links

Post by hanno »

subject says it, this causes invalid html/xhtml if one of the links contains an &.

Patch to fix:
http://files.hboeck.de/serendipity-escapersslink.diff

Please apply.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: remoterss plugin doesn't escape chars in links

Post by garvinhicking »

Hi!

Which RSS feed did you import? IMHO the RSS feed would be invalid, if a non-escaped character is in the link?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
hanno
Regular
Posts: 72
Joined: Fri May 20, 2005 8:04 am
Contact:

Post by hanno »

This one:
http://planet.hboeck.de/atom.xml

But problem only appears if ron gilbert blogs, because his blog has & in urls :-)

The feed IS escaped correctly, but the plugin somewhere seems to decode the escaping.
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Post by garvinhicking »

Hi!

Ah, I see :)

Thanks & Committed!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply