Amazon media grabber

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Amazon media grabber

Post by mgroeninger »

Ok, this is a little strange....
For personal reasons I have built an amazon media button for the new/edit entries page...

So, it allows a simple search of amazon and allows the user the ability to put a table of info into a post.

It is just a massive hack of serendipity_admin_image_selector.php...

I am _not_ a programmer, but it works for me...

My biggest problem is the number of files I have edited (created one, and edited atleast 2... plus all the language files), and my reluctance to do this again, when .8 comes out...

Any way I could hand it over to someone to clean up and put in CVS?
It should work for both editors, but I don't use to wysiwyg editor...

I'm just curious, really...


Thanks,
Matt
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Amazon media grabber

Post by garvinhicking »

For those reasons we usually add plugin event hooks and seperate all logic to a plugin, so that only the hook stub remains. Then you can include language strings in the plugin.

Creating files is a big no-no for additional development; we can include files like serendipity_functions_amazon.inc.php but not core files like 'serendipity_amazon.php'; and using event plugins this wouldn't even be neccessary.

If you could deliver us a CVS diff against the recent 0.7.1 release, I can try to investigate your code. If it's clean enough for me to work with, I can easily put it into a plugin.

Thanks for your effort and want to help with development!

Best regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
mgroeninger
Regular
Posts: 546
Joined: Mon Dec 20, 2004 11:57 pm
Contact:

Created a plugin.

Post by mgroeninger »

You can find the thread here:http://www.s9y.info/forums/viewtopic.php?t=753..

Thanks Garvin!
Post Reply