enhanced comment functionality

Random stuff about serendipity. Discussion, Questions, Paraphernalia.
Post Reply
ormus7577
Regular
Posts: 122
Joined: Sat Nov 04, 2006 12:11 pm
Location: Ulm, Germany

enhanced comment functionality

Post by ormus7577 »

Hi,

I really like that!

http://bueltge.de/erweiterung-der-komme ... ktion/862/
(german link - sorry. Just highlight some text in the entry and press the 'antworten' button to see the effect)

I know it's jQuery, but maybe it would be a nice option? I guess it can't be done in an plugin, it's in the core, right?
my installations:
family blog: http://familie.lobenstein.info/
personal blog: http://www.ormus.info/
OrmusTool Homepage: http://tool.ormus.info/
Online Adventskalender: http://www.ormus.info/pages/advent.html
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: enhanced comment functionality

Post by yellowled »

ormus7577 wrote:I know it's jQuery, but maybe it would be a nice option?
I also like it. But.

Whether implemented as a plugin or in the core, this would require either the plugin or core to also bundle jQuery. I'm not sure whether that's possible in terms of licenses ..?

YL
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: enhanced comment functionality

Post by yellowled »

yellowled wrote:Whether implemented as a plugin or in the core, this would require either the plugin or core to also bundle jQuery. I'm not sure whether that's possible in terms of licenses ..?
For the record (or Garvin): jQuery can be used with either MIT or GPL license.

YL
ormus7577
Regular
Posts: 122
Joined: Sat Nov 04, 2006 12:11 pm
Location: Ulm, Germany

Post by ormus7577 »

Actually this is much easier than I thought. It's all done by adjusting the theme!

I did add it to my Bulletproof Installation and it worked (for most parts) right away after adding a few classes.

Can be seen here: http://www.loben.org/ (sorry, german blog, just click an entry and highlight some entry text). I did deactivate most of the more advanced options (list related comments etc.)

Details about the javascript: http://donttrustthisguy.com/2009/01/04/ ... ommentary/

Only thing I couldn't do is having the comment content when pressing quote (quote button deactivated).

The javascript got a few weak spots though:
* no language setting
* classes should have prefix, entry-content is already used by Bulletproof but also by 'Encouraged Commentary'
my installations:
family blog: http://familie.lobenstein.info/
personal blog: http://www.ormus.info/
OrmusTool Homepage: http://tool.ormus.info/
Online Adventskalender: http://www.ormus.info/pages/advent.html
judebert
Regular
Posts: 2478
Joined: Sat Oct 15, 2005 6:57 am
Location: Orlando, FL
Contact:

Post by judebert »

Holy cow! Somebody else is actually using my Criterion colorset! For a second, I thought I was on my own blog. :shock:

That's a pretty neat script. But I notice it's using HTML for quoting. It was my impression that we stripped HTML from comments. Did you do something special to allow it?
Judebert
---
Website | Wishlist | PayPal
onli
Regular
Posts: 2828
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Post by onli »

Maybe we should simply add such a plugin containing jQuery? This way you could prevent the situation of two or more plugins using it manually (also used jquery for the commentpreview-plugin and working on another using it, too). I made a first version of a jquery-plugin which only shall serve as dependency.
Post Reply