[2.0] Smartifying the backend

Mark threads with "[2.0]" for discussions about features in the longer-term future, "[1.6]" is for short-term. This is not the place for general discussions or plugin or template requests. Only features that are approved to happen by the core team should be listed here for better structuring.
Locked
User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by garvinhicking » Tue Mar 27, 2012 1:48 pm

Timbalu wrote:looks like you are good in pestering too ;-)
...mine is shorter, but that one looks very professional! Its up to you.
I didn't yet understand your solution? I only saw a php include of a .tpl file? But that would mean converting the .tpl file to PHP first?

So I think Rodneys solution should be used in case of non-writable directory...

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Smartifying the backend

Post by Timbalu » Tue Mar 27, 2012 4:10 pm

garvinhicking wrote:I didn't yet understand your solution? I only saw a php include of a .tpl file? But that would mean converting the .tpl file to PHP first?
No. Have a deeper look at the commit. I got it working with that 'resource' eval display call and the && IN_installer !== true. Even tested with the YL prototype. No register necessary in my opinion, since used in this particular place (installer - step 1) only. I found Smarty well coded, as it seems no internal writable check is done, if using this resource eval display call.
garvinhicking wrote:So I think Rodneys solution should be used in case of non-writable directory...
As I said, its up to you.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by garvinhicking » Wed Mar 28, 2012 12:53 pm

Hi!

Ah, okay. WEll, if it works, we keep your solution. if there are problems at some point we can still try rodneys.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by yellowled » Wed Apr 04, 2012 2:11 am

I just tried to install a new dev blog based on a fresh 2.0 checkout.
Fatal error: Cannot redeclare serendipity_db_update() (previously declared in /foo/bar/include/db/db.inc.php:27) in /foo/bar/include/db/db.inc.php on line 56
after step 2b, i.e. fill out all the data needed for the installation. Any clues?

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Smartifying the backend

Post by Timbalu » Wed Apr 04, 2012 11:24 am

Hmmm, I do not have that. (I ran a test):
- Are you sure using the latest 2.0 and installer.inc? Maybe you have some other old files?
- Is this some kind of special server setup?
In functions_installer.inc.php around line 728 you can find two include_once calls. If you still have this problem... try replacing them with require_once.

Please also update installer.inc, as I just fixed an error with installation errors.
Replace head of new installer.inc.tpl with this:

Code: Select all

{* HTML5: Yes *}
{* From configuration to install *}
{if $is_errors && is_array($errors)}
    {foreach $errors AS $error}
    <span class="msg_error">{$error}</span>
    {/foreach}
{/if}
Last edited by Timbalu on Wed Apr 04, 2012 12:34 pm, edited 1 time in total.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Smartifying the backend

Post by Timbalu » Wed Apr 04, 2012 11:53 am

Garvin, is it possible to check and error if InnoDB (as this is the default mysql table engine) is used before db installation is done?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by garvinhicking » Wed Apr 04, 2012 12:37 pm

Timbalu wrote:Garvin, is it possible to check and error if InnoDB (as this is the default mysql table engine) is used before db installation is done?
Hm? mysql_error() should return results, that could be used?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Smartifying the backend

Post by Timbalu » Wed Apr 04, 2012 12:51 pm

But there is no error, as InnoDB is totally valid in the mysql world and s9y installs correctly, but it is no good with some Serendipity tables itself later on. That is why it might be a good idea to check this before install.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by yellowled » Wed Apr 04, 2012 1:18 pm

Timbalu wrote:- Are you sure using the latest 2.0 and installer.inc? Maybe you have some other old files?
- Is this some kind of special server setup?
Yes, it is the latest 2.0. Not sure about the server setup, I'll run a local test install against it.
Timbalu wrote:

Code: Select all

{* HTML5: Yes *}
{* From configuration to install *}
{if $is_errors && is_array($errors)}
    {foreach $errors AS $error}
    <span class="msg_error">{$error}</span>
    {/foreach}
{/if}
What exactly is this supposed to replace? I have:

Code: Select all

{if $i_success}
    return '<span class="msg_success">'. $s .'</span>';
{/if}
{if $i_warning}
    return '<span class="msg_notice">'. $s .' [?]</span>';
{/if}
{if $i_error}
    return '<span class="msg_error">'. $s .' [!]</span>';
{/if}
{if ( sizeof($smarty.post) > 1 && $s9yGETstep == 3 )}
    {if is_array($errors)}
        {foreach $errors AS $error}
        <span class="msg_error">{$error}</span>
        {/foreach}
    {/if}
{/if}
YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by yellowled » Wed Apr 04, 2012 1:20 pm

yellowled wrote:What exactly is this supposed to replace?
Never mind, I just saw it in your latest 2.0 commit.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by yellowled » Wed Apr 04, 2012 1:27 pm

yellowled wrote:Not sure about the server setup, I'll run a local test install against it.
Hmmm. Worked fine on localhost, so it might be the remote server setup. Sorry.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Smartifying the backend

Post by Timbalu » Wed Apr 04, 2012 1:36 pm

Would still be nice to find out..., as we had this (long time) before (viewtopic.php?f=1&t=3763).
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by garvinhicking » Wed Apr 04, 2012 2:32 pm

Timbalu wrote:But there is no error, as InnoDB is totally valid in the mysql world and s9y installs correctly, but it is no good with some Serendipity tables itself later on. That is why it might be a good idea to check this before install.
Please explain in depth what you mean, I don't understand any of this. :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by yellowled » Wed Apr 04, 2012 2:35 pm

Timbalu wrote:Would still be nice to find out..., as we had this (long time) before (viewtopic.php?f=1&t=3763).
I'm pretty sure it's some weird reaction to the server setup (I'll check with the hoster's support), but for the record: changing (@)include_once to (@)require_once does not help.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
yellowled
Regular
Posts: 7017
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [2.0] Smartifying the backend

Post by yellowled » Wed Apr 04, 2012 2:43 pm

Just did a test install on the same host w/ 1.6 – still doesn't complete the installation. This has to be some hiccup with the server.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

Locked