[1.6] Uninstall for plugins

Mark threads with "[2.0]" for discussions about features in the longer-term future, "[1.6]" is for short-term. This is not the place for general discussions or plugin or template requests. Only features that are approved to happen by the core team should be listed here for better structuring.
Locked
User avatar
Lux
Regular
Posts: 761
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

[1.6] Uninstall for plugins

Post by Lux » Fri Jan 14, 2011 7:00 pm

Hi

Please add a real uninstall possibility for plugins.

This should delete the plugin and all related data on disk and in the database, including any tables.

In my opinion this would go to the core features.

Cheers

Dirk
Last edited by Lux on Wed Jan 19, 2011 10:00 am, edited 1 time in total.

User avatar
yellowled
Regular
Posts: 7074
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [1.6] Unistall for plugins

Post by yellowled » Fri Jan 14, 2011 8:30 pm

I took the liberty of editing the topic to fit our versioning scheme for this subforum.

I second this, but it could be difficult to implement because of the (possible) mixture of plugins added manually and via spartacus. Also, permissions set by the spartacus plugin might be an issue here, especially given the fact that those can be configured in the plugin. Might be complicated to implement for various hosting situations, too.

Another thought: Have we ever thought about adding the spartacus plugin to the core? And yes, by that I mean making it possible to install plugins only through spartacus. From my point of view, anyone using S9y most definitely wants to use spartacus. I might not notice possible issues here, but is there a good reason for not using it? Is there a good reason for not making it the default and only way to add, remove and update plugins?

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [1.6] Unistall for plugins

Post by garvinhicking » Fri Jan 14, 2011 8:52 pm

Hi!

On my blog I have a CVS checkout of the additional_plugins module and symlink it into my plugins/ directory. I would never want to use spartacus...

Uninstalling indeed is a bit problematic because in more cases than not it will have write issues. Personally, I also like that uninstalling plugins does not completely remove it. The few bytes it saves is often not worth having to re-download a plugin if I want to enable it again. Also, if you made any custom changes to a plugin or .tpl file, you'd lose them forever...I don't really feel comfortable with this.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Lux
Regular
Posts: 761
Joined: Fri Aug 12, 2005 4:36 pm
Location: Grüt, Zürich, Switzerland
Contact:

Re: [1.6] Unistall for plugins

Post by Lux » Fri Jan 14, 2011 9:29 pm

yellowled wrote:I took the liberty of editing the topic to fit our versioning scheme for this subforum.

I second this, but it could be difficult to implement because of the (possible) mixture of plugins added manually and via spartacus. Also, permissions set by the spartacus plugin might be an issue here, especially given the fact that those can be configured in the plugin. Might be complicated to implement for various hosting situations, too.
Difficult does not mean impossible. And in this case we only have two possibilities to think of. Self-upload or Spartacus.

Even if it is not possible to delete the files, there could be an output or maybe even a document, where you can find all the files, configurations and tables for manual deletion.

I can imagine a mask showing these points:
delete files (plugins/serendipity_event_bla) yes/no
delete tables (prefix_bla1, prefix_bla2, ...) yes/no
delete configuration items (dataset id x in table y, ...) yes/no
yellowled wrote:Another thought: Have we ever thought about adding the spartacus plugin to the core? And yes, by that I mean making it possible to install plugins only through spartacus. From my point of view, anyone using S9y most definitely wants to use spartacus. I might not notice possible issues here, but is there a good reason for not using it? Is there a good reason for not making it the default and only way to add, remove and update plugins?
I used serendipity in a company network where the server was not allowed to connect to the internet.

But I agree for internet sites.
garvinhicking wrote:In my blog I have a CVS checkout of the additional_plugins module and symlink it into my plugins/ directory. I would never want to use spartacus...

Uninstalling indeed is a bit problematic because in more cases than not it will have write issues. Personally, I also like that uninstalling plugins does not completely remove it. The few bytes it saves is often not worth having to re-download a plugin if I want to enable it again. Also, if you made any custom changes to a plugin or .tpl file, you'd lose them forever...I don't really feel comfortable with this.
You are a developper and have different needs than other people. :-)

Cheers

Dirk

User avatar
Don Chambers
Regular
Posts: 3636
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: [1.6] Unistall for plugins

Post by Don Chambers » Fri Jan 14, 2011 9:51 pm

garvinhicking wrote:On my blog I have a CVS checkout of the additional_plugins module and symlink it into my plugins/ directory. I would never want to use spartacus...
What is your logic to this Garvin? And why would no never want to use spartacus?

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [1.6] Unistall for plugins

Post by Timbalu » Fri Jan 14, 2011 9:55 pm

good question, don!!! Is it unsecure, Garvin ???? :wink:

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [1.6] Unistall for plugins

Post by garvinhicking » Fri Jan 14, 2011 9:58 pm

Don Chambers wrote:
garvinhicking wrote:On my blog I have a CVS checkout of the additional_plugins module and symlink it into my plugins/ directory. I would never want to use spartacus...
What is your logic to this Garvin? And why would no never want to use spartacus?
Hi!

It's much easier to upgrade all plugins at once, I never have integrity issues, I never need to resort on mirrors and my local modifications will never get overwritten.

And of course, this is only for developers - I just wanted to object to yellowled to make spartacus mandatory.

As for the uninstall routine: If it would only report which files to delete when it's not possible, that of course can be achieved. An uninstall routine will also never be able to tell which database tables were created by a plugin; each plugin has to be changed for that, so full support for removal will always depend on the plugin maintainers or someones helpfulness to add the missing information to all plugins. ;)

I'll try to work on that to get this thing started a bit in the next weeks

regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Don Chambers
Regular
Posts: 3636
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: [1.6] Unistall for plugins

Post by Don Chambers » Fri Jan 14, 2011 10:16 pm

Thanks for the explanation! When you said it was for your personal blog, I was not thinking in terms of development.

User avatar
garvinhicking
Core Developer
Posts: 30020
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: [1.6] Unistall for plugins

Post by garvinhicking » Fri Jan 14, 2011 10:19 pm

Don Chambers wrote:Thanks for the explanation! When you said it was for your personal blog, I was not thinking in terms of development.
Yeah, no - I was also speaking of my blog on garv.in - this is completely powered on SVN and CVS, this is where I enjoy not using Spartacus.

Really, Spartacus is a great tool for many users - I only wanted to say that there are valid reasons for people not to want to use it :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
yellowled
Regular
Posts: 7074
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: [1.6] Unistall for plugins

Post by yellowled » Fri Jan 14, 2011 10:22 pm

garvinhicking wrote:On my blog I have a CVS checkout of the additional_plugins module and symlink it into my plugins/ directory. I would never want to use spartacus...
Yeah, this setup sounds familiar. :) I'm doing the same thing on my test server, but I know what I'm doing. (Well, more or less. :wink:)

However, this is not true for the vast majority of our users! The average John Doe user doesn't even know what CVS is, much less how to use it properly. I tend to encourage people, especially novice users, to use spartacus and use it from day 1, since it makes maintaining plugins so much easier. These are people who in most cases don't even like to use an FTP client or ssh. They like easy interfaces, and I think if it is at all possible to implement them in a sensible way, we should think about giving them the possibility to use easy interfaces ...

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

Locked