[2.0] Auto upgrade manager [developer needed]

Mark threads with "[2.0]" for discussions about features in the longer-term future, "[1.6]" is for short-term. This is not the place for general discussions or plugin or template requests. Only features that are approved to happen by the core team should be listed here for better structuring.
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

garvinhicking wrote:In the short run, it would be great to work on the dependency system and check if it can be improved to utilize spartacus to download plugins that are not yet locally existing...
Ahem, I remember us talking and thinking that it is eval to allow something automatic downloading, without user intro and submit, didn't we?
If I do remember correctly, this isn't really an option.

But bundling all needed dependencies plugins with a serendipity release, is a way to go, on condition that the main plugin (in our case the dashboard notifier) is an enabled core plugin.

Ian
onli
Regular
Posts: 2822
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by onli »

Timbalu wrote:
garvinhicking wrote:In the short run, it would be great to work on the dependency system and check if it can be improved to utilize spartacus to download plugins that are not yet locally existing...
Ahem, I remember us talking and thinking that it is eval to allow something automatic downloading, without user intro and submit, didn't we?
If I do remember correctly, this isn't really an option.
When? Had a discussion about this somewhere on a mailinglist or something? Hm, that sounds sarcastic, its not meant to. I really don't remember. Tough we talked in this thread about updates which should not be downloaded without userinput.

If you refer to this: This has nothing to do with that. A dependency-system should of course use spartacus if possible. We already have the input that the plugin the dependency is for shall be installed so we need to download the other one. In fact, i am quite a bit irritated that's not already happening (it explains all the post about the jQuery-dependency not working).

You use windows, don't you? A dependency-system is used on almost all linux-distributions. When you install a program, automatically all needed packages (subprograms, libraries etc) are fetched. A dependency-system not doing this isn't one.

Modifying the install-routine don't sound to hard, without looking at the code yet. On install, serendipity needs to check wether there are dependencies. If one of them is not already saved locally, check if spartacus can download it. If downloaded, install, if not, print an errormessage. Something missing or is there an obstacle i oversee? :)

PS: The last paragraph probably belongs in an own thread, maybe we also need to check the way dependencies are stored (is it possible to uninstall a dependency when the dependent plugin is still installed?)
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

onli wrote:If you refer to this: This has nothing to do with that. A dependency-system should of course use spartacus if possible. We already have the input that the plugin the dependency is for shall be installed so we need to download the other one. In fact, i am quite a bit irritated that's not already happening (it explains all the post about the jQuery-dependency not working).

You use windows, don't you? A dependency-system is used on almost all linux-distributions. When you install a program, automatically all needed packages (subprograms, libraries etc) are fetched. A dependency-system not doing this isn't one.
Yes, no sarcasm intended. I know about the linux way, having a server for years.
I think the only difference is I thought the notifier plugin is core, so why should it walk to spartacus to solve its dependencies needed for core?
If there is a plugin you have to install manually, it is ok grapping dependencies over spartacus, while you will get informed about it.

About the uninstall: At least unactivating the main plugin when uninstalling a dependency plugin is needed.

Ian
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

Hi

We still have to think about the dependencies problem:
  • I. If a plugin has dependencies to another plugin, it uses the s9y dependency method.
  • II. This one will install a dependency plugin only, if it is in the $classes range and physically in plugin folder.
  • III. To install automated into the plugin folder, we definitely need the spartacus plugin with the right settings pre installed, even if we screw up the dependency method.
This is getting quite detailled to be really bulletproof and save, I think.
If we are going this way, we are opening potentially another branch in s9y of getting more complicated.

The other way to avoid this, is to have these dependencies always send within a Serendipity release file, which is a base solution with full control.

The second way to solve this is to declare spartacus as a core plugin, and have a hook-in function inside to install dependencies automated. But we know Spartacus isn't an option everywhere.

This is getting complicated. The more I think about it, I prefer the simple base solution.
What do you think?

Ian
onli
Regular
Posts: 2822
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by onli »

I didn't have a look at the code yet. But i'd prefer if spartacus would fetch the dependencies and otherwise print a errormessage which plugin needs to be installed.
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

Hi Malte

Yes, but this indicates spartacus to be pre installed, meaning being in core, which isn't the default setting, while it is not an option everywhere. Wag the Dog, phenomenon! :wink:

Ian
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by blog.brockha.us »

I am testing this cool stuff the first time and I am impressed. :)

But shouldn't we switch that code from svn to git? And update the stable version info there to 1.6?
If nothing is to say against this, I would do this change now..
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
onli
Regular
Posts: 2822
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by onli »

just go ahead, the git-repo didnt exist at that time.
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by blog.brockha.us »

Perfect, thanks. :)
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by blog.brockha.us »

I don't understand, what the "beta" update check should produce.. :?:

It is fetching the newest nightly but only once when the beta version of the installed s9y does not change.. So you will have a somewhat random "beta" installed depending on when you call this check.

Example: At the moment the nightlys are "1.7-alpha1". If I would declare this as beta, the update checker would find a beta, dl the actual nightly and won't show another "beta" as the version will not change.

If we allow the user to start to install nightlys, there should be a new update each day, right? Or we never should deliver nightlys through this mechanism..
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

Grischa, that is true, as the dashboard is for the public!

We should stop that.

(btw. if you if you do that, you might also correct this not finished variable switch $nv vs $newVersion around ~line 447 to 450, which I just found trying to convert the dasboard to be smartified, I'll tell you when I am ready, so we do not push same things.)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by blog.brockha.us »

I'm not in that code at the moment (I committed my changes already yesterday).

I think, we should remove that beta downloading stuff. If someone want's to install beta stuff he/she is not afraid to do the manual ftp update.

And btw: When beta stuff is detected, the autoupdater is hooked. But this plugin is not able to handle it, as it is looking for releases only and there is no hook param telling it to look for nightlys.

So be free to change the code, I'm looking into other code atm (xml-rpc and bayes).
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

No, won't do that, as it is Maltes baby and coheres with autoupdater!

But I just fixed these overseen vars in yesterdays commit ;-)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
blog.brockha.us
Regular
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany
Contact:

Re: [2.0] Auto upgrade manager [developer needed]

Post by blog.brockha.us »

you are ophian at GitHub?
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0] Auto upgrade manager [developer needed]

Post by Timbalu »

Yes.

Ian standalone was already taken. :wink:
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
Locked