jquery grumbles

Discussion corner for Developers of Serendipity.
Post Reply
User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

jquery grumbles

Post by Timbalu » Tue Apr 29, 2014 12:38 pm

Firefox Developer Console always alerts( and has been doing this quite a long time by now):
jquery.js is being assigned a //# sourceMappingURL, but already has one
I know we have talked about that prior, but I can't find the place we did.
I now figured out it is this line in /templates/jquery.js (https://github.com/s9y/Serendipity/blob ... uery.js#L5)

Code: Select all

//# sourceMappingURL=jquery.min.map
If we remove the source mapping by deleting this line completely, even if it looks disabled, everything is OK. Thanks!

YL, how did it come in there, since a normal minified query file should not have it ?! (see http://code.jquery.com/jquery-1.11.0.min.js)
Maybe second last comment http://stackoverflow.com/questions/2175 ... dy-has-one helps.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7056
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: jquery grumbles

Post by yellowled » Tue Apr 29, 2014 1:55 pm

Timbalu wrote:YL, how did it come in there, since a normal minified query file should not have it ?! (see http://code.jquery.com/jquery-1.11.0.min.js)
OH. :oops:

I usually use Bower in my web projects to manage the JS assets I need. Apparently, the jquery.min.js included in the Bower package has that line (it also includes a jquery.min.map, so it makes sense). I wasn't even aware of that.

So I probably at some point used a local copy of jquery.min.js pulled from Bower to update the jquery.min.js in s9y. I just committed a version without the source mapping line to the 2.0 branch.

Sorry about that.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

Post Reply