major release upgrading bundled libs?

Discussion corner for Developers of Serendipity.
User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: major release upgrading bundled libs?

Post by garvinhicking » Thu May 08, 2014 10:55 am

Hi!

Sounds good to me...would you be willing to prepare a pull request, feature branch or something like that?!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
mattsches
Regular
Posts: 435
Joined: Sat Nov 05, 2005 10:35 pm
Location: Wiesbaden, Germany
Contact:

Re: major release upgrading bundled libs?

Post by mattsches » Thu May 08, 2014 10:27 pm

Why not commit it directly to the 2.0 branch? The only file that's actually changed is PEAR.php, everything else is an addition.

But if you prefer a pull request, I can also fork the 2.0 branch, add the feature to my fork, and create a PR.

Regards,
Mattsches

User avatar
garvinhicking
Core Developer
Posts: 30014
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: major release upgrading bundled libs?

Post by garvinhicking » Fri May 09, 2014 4:34 pm

mattsches wrote:Why not commit it directly to the 2.0 branch? The only file that's actually changed is PEAR.php, everything else is an addition.
Sure, no problem :) I wasn't sure yet how many changes that would mean. Would be fine for me in 2.0 directly.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
mattsches
Regular
Posts: 435
Joined: Sat Nov 05, 2005 10:35 pm
Location: Wiesbaden, Germany
Contact:

Re: major release upgrading bundled libs?

Post by mattsches » Fri May 09, 2014 5:48 pm

Pushed. I hope I've included all required libs and dependencies. Please test 8)

Regards
Mattsches

Post Reply