2.0 End of Alpha Talk

Discussion corner for Developers of Serendipity.
User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: 2.0 End of Alpha Talk

Post by Timbalu » Tue Feb 25, 2014 8:01 pm

onli wrote:
garvinhicking wrote:Maybe there's a way to utilize smarty in that scenario without it needing to write to a directory yet.
That is already solved, I think Ian solved that for the installer way back when :) smarty->eval or something.
Yeah, "he" did that to the installer! Which will still work, I assume, if nothing essential has changed till then.
But this topic is about upgrader page, which is somethink completely different.

I was able to solve this issue by just moving the upgrader content into an index wrapper. (https://github.com/s9y/Serendipity/comp ... 8c6b27aedb)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Tue Feb 25, 2014 8:38 pm

Timbalu wrote:I was able to solve this issue by just moving the upgrader content into an index wrapper. (https://github.com/s9y/Serendipity/comp ... 8c6b27aedb)
… and I followed up by finally prettyfying the upgrader to match the installer.

So thanks to Ian were now officially down to the last open issue in the backend, which really is only half an issue, and that half is not critical for the beta. (It's more like a “would be nicer if, but doesn't have to be, and maybe I'm also overthinking this” kind of thing.)

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: 2.0 End of Alpha Talk

Post by Timbalu » Tue Feb 25, 2014 8:53 pm

Much better! :)
That is what I meant with my commit note, regarding the need for a "little tweaking by header and messaging, which take a little too much room".
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Tue Feb 25, 2014 9:43 pm

Timbalu wrote:Much better! :)
That is what I meant with my commit note, regarding the need for a "little tweaking by header and messaging, which take a little too much room".
If you consider that the markup and styling previous to your fix was written without any way to control how it looks, I think it worked pretty well. :wink: (Indeed, it now looks much better.)

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
mattsches
Regular
Posts: 435
Joined: Sat Nov 05, 2005 10:35 pm
Location: Wiesbaden, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by mattsches » Wed Feb 26, 2014 1:09 pm

garvinhicking wrote:Ideally I'd like to try the mumble recording feature, not for a public upload, but for us to create notes from afterwards. If one of us four people is busy with creating notes, that would draw some time...
We should definitely do that. We could also open an Etherpad to collaboratively scribble down notes while we speak.

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Wed Feb 26, 2014 3:52 pm

mattsches wrote:We should definitely do that. We could also open an Etherpad to collaboratively scribble down notes while we speak.
I think recording the whole think and writing a summary later is the way to go. We can, however, write the protocol in Etherpad later. Or in a shared Dropbox document.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Don Chambers
Regular
Posts: 3633
Joined: Mon Feb 13, 2006 3:40 am
Location: Chicago, IL, USA
Contact:

Re: 2.0 End of Alpha Talk

Post by Don Chambers » Thu Feb 27, 2014 7:35 pm

If you are going to record it, can you so so in English as much as possible? :wink: I'd love to get a grasp of the meeting, even if I cannot join you guys.

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Thu Feb 27, 2014 8:43 pm

Don Chambers wrote:If you are going to record it, can you so so in English as much as possible? :wink: I'd love to get a grasp of the meeting, even if I cannot join you guys.
There will be a transcript in English, don't worry. Might take a few days, though.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
mattsches
Regular
Posts: 435
Joined: Sat Nov 05, 2005 10:35 pm
Location: Wiesbaden, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by mattsches » Fri Feb 28, 2014 1:46 pm

Anything I should do in preparation for the Mumble tomorrow?

Haven't had much time to track the latest developments re the new backend, but if you want me to take a look at sth. beforehand, please let me know.

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Fri Feb 28, 2014 1:50 pm

mattsches wrote:Anything I should do in preparation for the Mumble tomorrow?
Right now, I think the most time-consuming point on our todo list would be showing you guys around in the backend. I know Garvin already took a closer look at the backend, so I guess it would save us some time if you could do that as well.

You can use my 2.0 dev blog for that, your login from last time should still work. Ping me if not (unfortunately, I'll not be near a computer between 15:00 and 18:00 today).

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Tue Mar 04, 2014 11:27 am

yellowled wrote:There will be a transcript in English, don't worry.
Not sure what to transcribe here. Let's see what we discussed …

– I gave a short introduction to what we changed since getting feedback in a closed alpha test.
– We discussed the open UI/UX issues that I had. That included exchanging some icons used, keeping the colors used (at least for the time being) and switching to an off-canvas nav on small screens instead of the mobile dropdown.
– Discussion: what needs to be done before this can be “shipped” as a beta – optimization of backend CSS/JS, testing in IE and mobile browsers, no-js fallback etc.
– Discussion about the default plugin selection, but without actually discussing which plugin could be removed or added (this seems a better discussion for the forums).
– I still want to adapt the backend sections created by additional plugins. Garvin will provide an example as to how to use a version detection to emit different markup for 1.7.x and older/2.0 backends.
– We don't want to set a precise timeframe for the beta phase. End of march might be realistic depending on the open issues and required testing. Adapting plugins will not be part of the beta phase. “Beta” means people can test 2.0 in a non-productive environment.
– Timbalu had a list of smaller issues, potential issues and concerns. I can't really list all of them since some of them are out of my area of expertise, but I think we were able to find solutions or ways to solve them.

(This is about the time Garvin had to leave. I'm not sure if what we discussed after that is still relevant. I'll list the important stuff anyway.)

– We might want to make the new core dashboard extendable so that other plugins(?) can add functionality to the core dashboard. (Doesn't have to be implemented for beta.)
– Already added to 2.0 by Timbalu: a new function (in the Maintenance section) to purge templates_c.
– Some minor UI/UX issues which I have (kind of) fixed already, i.e. zebra striping, the info buttons.
– Lengthy debate about details/summary (used for categories) in Chrome vs Firefox. For everyone involved: it is actually a bug in Firefox – mind the reported date of the bug … :shock:
– We also revisited the discussion as to why the Karma plugin does not emit anything in the backend (which we also discussed in the first leg of the dev talk). No solution though, since nobody really uses it.

… and then we called it a day.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: 2.0 End of Alpha Talk

Post by Timbalu » Tue Mar 04, 2014 3:28 pm

yellowled wrote:– Lengthy debate about details/summary (used for categories) in Chrome vs Firefox. For everyone involved: it is actually a bug in Firefox – mind the reported date of the bug … :shock:
Something not implemented yet is not a bug IMO, it is just something not being supported by now, because of certain reasons.

But it would be nice to have, thats right! :)

So I twiddled a bit and tried to fake this with Firefox as much as I could.

It does only work with using the pseudo class :active, which does not stay open when clicking the selector somewhere, but behaves as wanted when clicking the triangle. So active will make the triangles appear and do their work with details open/close.

Code: Select all

@-moz-document url-prefix() {
    details > summary:before{
        float: left; width: 2em; 
        content: "\25BA"; /* U+25BA: BLACK RIGHT-POINTING POINTER - fallback */
        content: content: '► ';
    }
    /* do not use as details>summary - see below */
    details > .category_info {
        display: none;
        visibility: hidden;
    } 
    details:active > summary:before {
        content: "\25BC"; /* U+25BC: BLACK DOWN-POINTING TRIANGLE - fallback */
        content: '▼ ';
    }
    /* using these class selectors are a need to get this to work with Mozilla */
    .category_data:active > .category_info {
        display: block; 
        visibility: visible;
    }
}
(updated)
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: 2.0 End of Alpha Talk

Post by Timbalu » Tue Mar 04, 2014 4:31 pm

Simple switch for YL

Code: Select all

// do not use in 2.0 versions
if ($serendipity['version'][0] == '1') {
    // do something old version
} else {
    // new
}
oder

Code: Select all

if ($serendipity['version'][0] == '2') { // new }
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7005
Joined: Fri Jan 13, 2006 12:46 pm
Location: Eutin, Germany
Contact:

Re: 2.0 End of Alpha Talk

Post by yellowled » Tue Mar 04, 2014 5:37 pm

Timbalu wrote:Something not implemented yet is not a bug IMO, it is just something not being supported by now, because of certain reasons.
Well, it is in their bugtracker. I didn't read much further than that because browser vendor bugtrackers are usually about the most complicated thing one can imagine. I'm sure it will get implemented at some point.
Timbalu wrote:So I twiddled a bit and tried to fake this with Firefox as much as I could.
If we do want to “fix” this, I'd rather use a JS polyfill for the details element, because that would make it work in IE as well. (IE doesn't even support details/summary in current versions.)

Personally, I don't think it's necessary because it's just a visual difference.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: 2.0 End of Alpha Talk

Post by Timbalu » Tue Mar 04, 2014 9:06 pm

Yeah, as you like. I just played around and was interested, if it was fakeable with pur CSS only. :)

But I think, as long as Mozilla (and IE) do not support it, we should use something like a polyfill to behave the same.
Btw, do you know this one https://github.com/mathiasbynens/jquery-details ?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

Post Reply