checksum check in testing

Discussion corner for Developers of Serendipity.
Post Reply
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

checksum check in testing

Post by Timbalu »

For the internal verify checksum function I would like to add a check for an empty checksum file, which happens in non released Serendipity testing versions. Else a click will always pronounce the checksum check to have run through successfully, which isn't true.

It is not a big thing, but before I put this on Github I would like to have a quick feedback, if this also can end up with CHECKSUMS_NOT_FOUND, 'Unable to compare checksums! (No checksums.inc.php in main directory)', or better stay on its own with a new constant CHECKSUMS_EMPTY, "Unable to compare checksums! (Possibly because a testing version is currently installed)".

Then I would need Garvin to create this in the lang files for us, please. :wink:
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: checksum check in testing

Post by garvinhicking »

Hi!

I think we can use the existing constant for that.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
Post Reply