Working on 2.0: Developer sprint

Discussion corner for Developers of Serendipity.
User avatar
Don Chambers
Regular
Posts: 3638
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Working on 2.0: Developer sprint

Post by Don Chambers » Tue Nov 20, 2012 3:26 pm

Have not tried Ian's new version, but last night I tried upgrading an existing s9y test installation to 2.0, and I am getting a white page with a title of "== TESTING ERROR MODE == " followed by the output of every single array. What's up with that?

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Working on 2.0: Developer sprint

Post by Timbalu » Tue Nov 20, 2012 3:29 pm

???
Well, at least the first array lines or the exception Fatal error lines at the end would be needed to know what happened.
Last edited by Timbalu on Tue Nov 20, 2012 4:04 pm, edited 2 times in total.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3638
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Working on 2.0: Developer sprint

Post by Don Chambers » Tue Nov 20, 2012 3:32 pm

Very end is:

Code: Select all

Fatal error: Uncaught exception 'ErrorException' with message 'Serendipity error: Declaration of serendipity_event_forgotpassword::event_hook() should be compatible with that of serendipity_event::event_hook()' in /var/www/vhosts/sitethreetest.com/include/compat.inc.php:108
Stack trace:
#0 /var/www/vhosts/sitethreetest.com/include/plugin_api.inc.php(580): errorToExceptionHandler(2048, 'Declaration of ...', '/var/www/vhosts...', 272, Array)
#1 /var/www/vhosts/sitethreetest.com/include/plugin_api.inc.php(580): serendipity_plugin_api::load_plugin()
#2 /var/www/vhosts/sitethreetest.com/include/plugin_api.inc.php(992): serendipity_plugin_api::load_plugin('serendipity_eve...', '0', 'serendipity_eve...')
#3 /var/www/vhosts/sitethreetest.com/include/plugin_api.inc.php(1041): serendipity_plugin_api::get_event_plugins()
#4 /var/www/vhosts/sitethreetest.com/include/functions_config.inc.php(535): serendipity_plugin_api::hook_event('backend_login', false, NULL)
#5 /var/www/vhosts/sitethreetest.com/include/functions_config.inc.php(380) in /var/www/vhosts/sitethreetest.com/include/compat.inc.php on line 108

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Working on 2.0: Developer sprint

Post by Timbalu » Tue Nov 20, 2012 3:56 pm

That says:
The event plugin serendipity_event_forgotpassword.php method (function) event_hook(...) call needs to be fully compat with the origin core function. As far as I remember Grischa has solved this for every event plugin in additional_plugins. As you have serendipity_event_forgotpassword there, it seems this is not an official plugin, or you did not upgrade to its new version. The line has to look like:

Code: Select all

function event_hook($event, &$bag, &$eventData, $addData = null) {
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3638
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Working on 2.0: Developer sprint

Post by Don Chambers » Tue Nov 20, 2012 4:49 pm

I merely copied the 2.0 files to an existing s9y installation. When I remove the plugin from the database, I get the same error for the next plugin in the table. Are you saying every event plugin has to be upgraded before upgrading s9y core to 2.0?

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Working on 2.0: Developer sprint

Post by Timbalu » Tue Nov 20, 2012 4:56 pm

No, I say, if using a testing developer version like 1.7 or 2.0, you have a more strict error reporting, as this is testing, not release. If it is testing, you should at least have the latest state for all files used. This means also all files installed via additional_plugins. And I can say, these kind of errors did touch a lot of files. Its only something the error reporting and the php version wants us to be strict for the future! ;-)
So basically "Nearly, Yes!" is the answer!
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
Don Chambers
Regular
Posts: 3638
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Working on 2.0: Developer sprint

Post by Don Chambers » Wed Nov 21, 2012 5:17 pm

I finally have a working 2.0 install with YL's latest changes. @YL - is there anything you are NOT working on just yet? You seem to be modifying many files every day. Also, is there any specific logic you are following with your modifications?

User avatar
yellowled
Regular
Posts: 7092
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Working on 2.0: Developer sprint

Post by yellowled » Wed Nov 21, 2012 6:23 pm

Don Chambers wrote:is there anything you are NOT working on just yet? You seem to be modifying many files every day.
That seems about right. :mrgreen:

I prefer to use lots of small commits (and I recommend everyone do the same because it really doesn't help to change a lot in one commit), which is probably why it seems way more than it actually is.
Don Chambers wrote:Also, is there any specific logic you are following with your modifications?
Well, I spend yesterday and today mostly finishing the conversion to HTML5, although it is not “much” HTML5 just yet but merely proper, up to date markup. Most of this stuff hasn't been touched in ages, and it shows.

This goes along with a lot of quality assurance, i.e. removing inline CSS and JS (where possible without – hopefully – breaking anything), rearranging attributes so the markup is consistent, etc. Sometimes, something will cross my mind while I'm working at something else (which is probably why you don't see a specific logic), also Ian has been finding some last-minute bugs which needed to be worked in inbetween changes. Then there's the occasional commit which is necessary just because I'm not that skilled with git yet and need to revert my changes in a weird way. :roll:

I also managed to rewrite most of the markup for the media db today. It's still quite a mess, but that's mostly because the media db's JS is pretty complicated and requires a specific markup to work at some points (which means I can't change the markup there, but that's only one tpl file).

I guess it's a wrap for now in terms of markup, so I'll try and get started on a very basic design tomorrow so we'll have something decent to look at and discuss in the next developer sprint.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Don Chambers
Regular
Posts: 3638
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Working on 2.0: Developer sprint

Post by Don Chambers » Wed Nov 21, 2012 9:00 pm

I''l start with your latest admin/index.tpl and see if I can come up with any inspiration.

User avatar
yellowled
Regular
Posts: 7092
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Working on 2.0: Developer sprint

Post by yellowled » Thu Nov 22, 2012 3:03 pm

Just a heads up: I didn't really get to styling the backend yet, some client work changed my schedule for today. What I have committed/am committing also is merely trying it on for size. It might (and likely will) end up looking very different, especially since there might be some layout/usability changes we need to discuss further before actually implementing them.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Working on 2.0: Developer sprint

Post by Timbalu » Fri Nov 23, 2012 8:28 am

yellowled wrote:I didn't really get to styling the backend yet, .... What I have committed/am committing also is merely trying it on for size.
But as I have seen this morning, you are doing a fucking good job!!! THUMBS UP! :D
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7092
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Working on 2.0: Developer sprint

Post by yellowled » Fri Nov 23, 2012 2:01 pm

The thing is, when I actually get around to designing stuff, I look under the hood and find stuff that still needs to be fixed in the markup. Very annoying. I haven't even gotten around to just trying to understand the JS yet, let alone port it to jQuery.

It's like I posted on Twitter a few days ago: this is going to be much, MUCH more work than anyone of us is aware now …

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: Working on 2.0: Developer sprint

Post by Timbalu » Fri Nov 23, 2012 2:12 pm

I noticed that when working with the PoC Dashboard... ;-)
If you need some help with it, drop a note.
And what about all these left alone br linebreaks, which I dimley remember still to be in core... Isn't this something we should switch off with your new code?
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian

User avatar
yellowled
Regular
Posts: 7092
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Working on 2.0: Developer sprint

Post by yellowled » Fri Nov 23, 2012 2:34 pm

Timbalu wrote:If you need some help with it, drop a note.
Well, it would really help if someone with a better knowledge of native JS than me went over all the JS stuff and maybe documented what it actually does.
Timbalu wrote:And what about all these left alone br linebreaks
Good point, that's another thing I should grep for.

YL
amazon Wishlist - Serendipity-Podcast (German only, sorry)

User avatar
Don Chambers
Regular
Posts: 3638
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Working on 2.0: Developer sprint

Post by Don Chambers » Fri Nov 23, 2012 5:35 pm

I am also working on some backend design as I am not sure what else to work on. One immediate question - are we continuing to use the Nuvola icon set, or should we consider something else?

Post Reply