Diff Google +1 serendipity_event_findmore

[seraphyn]

This is the diff for Google +1.
This will use the correct URL and Blogpostitle too in the overview.
plugin_findmore.tpl:

Code: Select all

109,111d108
<  {if NOT $findmore_disabled_services.plusone}
< <div class="facebook_like"><g:plusone size="small" count="false" href="{$entrydata.url}"</g:plusone></div>
< {/if}

serendipity_event_findmore.php:

Code: Select all

4d93
<                       'plusone'       => 'plusone',
256c255
<                   echo '<script type="text/javascript" src="https://apis.google.com/js/plusone.js"></script>'."\n";
---
> 

Will make a selection for size and with/without number too

Chris

[garvinhicking]

Hi!

Committed, thanks a lot. In the future, could you please attach/provide a single unified diff for patches? I had to manually copy/paste your different sources, and it would be great if I could just "patch < yourfile.txt"

Regards,
Garvin

[seraphyn]

I will.
By the way, there should be an option to do not load the Google-Script if it is not used.
Is there a possibility to wirte this directly into the php-code at the end, ro should there be set normally a variable?
Chris

[garvinhicking]

Hi!

I've actually patched that in in your commit

Regrads,
Garvin

[seraphyn]

Great Thanks
I'll have a look at the sources tomorrow

[Lux]

Hi!

Unfortunately, I am not able to update to the recent version of the plugin.

I removed it from the documentation, from disk and from the event tables in MySQL. The XML-files in templates_c were deleted as well. Afterwards I installed it and "only" version 1.19 appears.

Looking for "new versions of event plugins" I see there is a 1.20, but after installing the new version I can only find the existing 1.19 on disk.

What to do?

Cheers

Dirk

[Czorneboh]

Hi!

I am wondering about the same like Dirk. Updating to 1.20 doesn´t work, although I downloaded 1.20-version from Spartacus http://spartacus.s9y.org/index.php?mode ... s_event_en.

No changes in the backend for this plugin.

[seraphyn]

I do not tried it today.
I still use the selfpatched one.
Later this day, I could have a look, because I'll make an option for the +1 Icons, too.
Hopefully I understand what Garvin did, I not a real programmer of course
Chris

[garvinhicking]

Hi!

Lux: Which mirror do you use for downloading? SF.Net CVS is currently down, so maybe you'd need to download from netmirror or spartacus.s9y.org directly?

Czorneboh: What do you mean with "doesn't work"? Which version does your backend report? If you edit the plugin_findmore.tpl template from the plugin, does it contain the plusone reference?

Regards,
Garvin

[Lux]

Hi Garvin,

Lux: Which mirror do you use for downloading? SF.Net CVS is currently down, so maybe you'd need to download from netmirror or spartacus.s9y.org directly?

meanwhile I updated. Everything works. I am using netmirror.org.

Cheers

Dirk

[Czorneboh]

Hi Garvin

The first try to install was on Saturday: I downloaded the version manually from Spartacus and uploaded it with Filezilla into the plugin folder. After clicking "updating" I got a failure message "Bad Gateway", what I get always for the freetag_plugin (stucks at 3.16 in my blog), but not always for each plugin update. Sometimes an update after that failure message seems neverless to have been succesful. But perhaps not this time. What was reported after uploading with Filezilla, I already do not remember, but I guess 1.20, like Lux described.

But yesterday (Sunday) I have seen again the notice, that 1.20 is available and then the installation functioned and the Google plusone is now visible.

[CBieck]

Hi,

was there a rollback? I checked all mirrors (manually and per plugin) and can only find version 1.19 - e.g. http://netmirror.org/mirror/serendipity ... _findmore/ - it says July 21st, but the file does not contain plus one and changelog only goes up to 1.19...

Tx
Chris

[garvinhicking]

Hi!

Indeed, very odd! The file somehow got lost on the CVS server. I just recommitted it, and I hope it will appear properly now (should be updated on the mirrors on the next run tomrrow)

Regards,
Garvin

[seraphyn]

Great, have had a look in Spartacus and he never presents me an update of this plugin.
Thought it was my fault indeed.
Greetings and a nice weekend
Chris