Cleaner html for Commentpage in Backend

Discussion corner for Developers of Serendipity.
Post Reply
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Cleaner html for Commentpage in Backend

Post by onli »

The attached file is a version of the commentpage which tries to have almost the same look without using tables. It also adds the <prev> - <next>-buttons to the bottom of the page.

Why to cleanup the html? Because I had use for the commentpage in the bayes-plugin and didn't get along with the existing html, so this is my try to have it easier the next time something shall be changed.
sincerely
Attachments

[The extension php has been deactivated and can no longer be displayed.]

garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Cleaner html for Commentpage in Backend

Post by garvinhicking »

Hi!

Hm, what I don't like so much is the inline styling. I'd like to remove that, and make sure that the required CSS classes are added to those CSS admin stylesheets that come with the core:

Code: Select all

./default-rtl/admin/style.css
./default/admin/style.css
./competition/admin/style.css
./bulletproof/admin/style.css
./contest/admin/style.css
./carl_contest/admin/style.css
So maybe it could then also be checked if the CSS of those admin templates still works with the new structure? Maybe some CSS stylesheets use td.blabla instead of span.blabla!?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

I'll have a look upon the stylesheets. I didn't worked directly with external css because I thought it'd be easier to take one step after another.
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

Together with yellowled I changed the comment.inc.php once again. The admin-stylesheets seems to work fine with it, if the code is added to their style.css. Only the rtl-template seems to be a bit weird, but I think that's maybe even without the changes that way...

The code:

Code: Select all

#serendipityAdminCommentForm {
    line-height: 1.4em;
}

.serendipityAdminCommentNavigation {
    text-align: center;
}

.serendipityAdminCommentNavigationBack {
    float: left;
}

.serendipityAdminCommentNavigationNext {
    float: right;
}

#serendipityAdminCommentFilterForm {
    text-align: center;
    line-height: 1.8em;
    overflow: auto;
}

.serendipityAdminCommentFilterFormBox {
    float: left;
    width: 32%;
    display: inline;
    margin-left: 1%;
}


#serendipityAdminCommentFilterForm ul {
    list-style-type: none;
    margin: 0;
    padding: 0;
    text-align: left;
}

.serendipityAdminCommentFilterFormInput {
    width: 59%;
    float: right;
}

.serendipityAdminCommentFilterFormLabel {
    width: 40%;
}

#serendipityAdminCommentFilterForm .input_textbox {
    width: 100%;
}

.serendipityAdminCommentFormList {
    list-style-type: none;
    margin: 0;
    padding: 0;
}

.serendipityAdminCommentFormTech {
    float: right;
    width: 50%;
}

.serendipityAdminCommentFormMain {
    display: block;
    width: 30%; 
    margin-bottom: 2em;
}

.serendipityAdminCommentRemove {
    float: left;
    position: relative;
    margin: 1em;
}

.serendipityAdminCommentFormName {
    position: relative;
    margin-left: 2em;
}

.serendipityAdminCommentControls {
    border: 1px solid #CCCCCC;
    clear: both;
}

.serendipityAdminCommentHeaderImage {
    width: 22px;
    height: 22px;
    border: 0px;
    padding-right: 4px;
    vertical-align: middle;
}

.serendipityAdminCommentFullBody {
    display: none;
}
Or shall I attach the files?
Attachments

[The extension php has been deactivated and can no longer be displayed.]

yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: Cleaner html for Commentpage in Backend

Post by yellowled »

onli wrote:Only the rtl-template seems to be a bit weird
Without having looked at it specifically, I'd assume that all the alignment and floating messes with the general right-to-left orientation of that. No idea how to fix that, however.

YL
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Cleaner html for Commentpage in Backend

Post by garvinhicking »

Hi!

Once 1.5 is released I'll try to incorporate this to the 1.6. trunk!

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

Looking forward. But I forgot to add the ids of the comments. Fixed.

PS: Fixed some semantic and layout-errors.
Attachments

[The extension php has been deactivated and can no longer be displayed.]

onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

1.5 is out, already found time for this? I found myself messing with the commentpage once again ;)
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Cleaner html for Commentpage in Backend

Post by garvinhicking »

Hi!

Personally I didn't have the time yet...do you still have a fully working patch that would apply against s9y 1.6-alpha?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

Probably even the old one would - I'll test it, or create one.
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

The attached patch works :)
In addition to the patch, the css-code from below has to get added to the admin-style.css-flies. Is that something I have access to or will you take care of that? :)
Attachments
comment.inc.php.diff.txt
(28.13 KiB) Downloaded 412 times
Don Chambers
Regular
Posts: 3652
Joined: Mon Feb 13, 2006 2:40 am
Location: Chicago, IL, USA
Contact:

Re: Cleaner html for Commentpage in Backend

Post by Don Chambers »

I have not tried the patch. What css needs to get into the admin stylesheet and why?
=Don=
onli
Regular
Posts: 2825
Joined: Tue Sep 09, 2008 10:04 pm
Contact:

Re: Cleaner html for Commentpage in Backend

Post by onli »

The css from this post above. As I removed the table, we need floats and stuff to achive a proper look of that section.

PS: Remember the intention - I wanted to be able to easier modify the comment-page like I did for the bayes-plugin.

PPS: As i completed all modifications i wanted by now with the table-layout, it's not that important anymore for me.
Post Reply