Search found 434 matches

by mattsches
Wed Apr 30, 2014 11:46 am
Forum: Development
Topic: major release upgrading bundled libs?
Replies: 18
Views: 6603

Re: major release upgrading bundled libs?

Editing external libs usually is not a good idea. However, HTTP_Request was last updated on 2008-11-17 . So I don't expect a lot of security fixes soon :lol: Which means that I could totally live with this approach. But for any *new* contributions, HTTP_Request2 should of course be called directly. ...
by mattsches
Mon Apr 28, 2014 7:12 pm
Forum: Development
Topic: major release upgrading bundled libs?
Replies: 18
Views: 6603

Re: major release upgrading bundled libs?

It works ! For the HTTP_Request2 lib and its dependencies, check today's commits to my S9y fork. For a possible solution in a plugin, check this commit . We could even extract the if/else/try/catch-stuff to a method somewhere in serendipity_plugin or so. All in all, it should not be too much of a h...
by mattsches
Mon Apr 28, 2014 4:11 pm
Forum: Generelles in Deutsch
Topic: Plug-In Usergallery mit alt und title Texten
Replies: 6
Views: 1724

Re: Plug-In Usergallery mit alt und title Texten

Ich habe auch kurz draufgeschaut. serendipity_fetchMediaProperties() mit der passenden Image-ID als Parameter scheint das Mittel der Wahl zu sein. Schau dir die Rückgabe der Methode aus, da steht dann irgendwo der ALT-Paramter drin. Den kannst du dann z.B. als $image['alt'] setzen. Du müsstest dann ...
by mattsches
Sun Apr 27, 2014 7:45 pm
Forum: Development
Topic: major release upgrading bundled libs?
Replies: 18
Views: 6603

Re: major release upgrading bundled libs?

Keep in mind that some plugins are using HTTP_Request et al, too. So if we replace/update the libs, we have to think about a switch or fallback, something along the lines of

Code: Select all

//pseudocode
if (file_exists(HTTP_Request2)) {…} else {…}
by mattsches
Sun Apr 27, 2014 10:37 am
Forum: Development
Topic: major release upgrading bundled libs?
Replies: 18
Views: 6603

Re: major release upgrading bundled libs?

Hi, I'm bringing up this thread again because it showed up when I searched for "bundled-libs AND old" :lol: As mentioned elsewhere I'm playing around with running unit tests for plugins on Travis CI. The service offers to run the tests against HHVM, Facebook's new, PHP compatible runtime. Turns out ...
by mattsches
Sat Apr 26, 2014 10:20 am
Forum: Bugs
Topic: [2.0.0beta2] serendipity_event_freetag
Replies: 23
Views: 6064

Re: [2.0.0beta2] serendipity_event_freetag

Maybe we can find a solution that is editor agnostic and works even for non-WYSIWYG editors. I haven't checked out onli's approach yet, but from what I read in the corresponding thread this could be a possible solution.

Mattsches
by mattsches
Fri Apr 25, 2014 7:20 pm
Forum: Bugs
Topic: [2.0.0beta2] serendipity_event_freetag
Replies: 23
Views: 6064

Re: [2.0.0beta2] serendipity_event_freetag

I tested the serendipity_event_autosave plugin with 2.0-beta and the new backend. I did not dig in deep, just tried to get it to run and see if it autosaves an entry. Conclusion: It doesn't work anymore. It is the cause for some JS errors in the entry view, whether WYSIWYG is enabled or not. That pr...
by mattsches
Thu Apr 24, 2014 1:02 pm
Forum: Generelles in Deutsch
Topic: V 2.0 Beta2 Installationsproblem
Replies: 32
Views: 5468

Re: V 2.0 Beta2 Installationsproblem

Sieht so aus, als würdest du das Theme "bulletproof" verwenden. Möglicherweise hilft es, wenn du hier testhalber mal auf das Default-Theme bzw. "2k11" umstellst.
by mattsches
Wed Apr 23, 2014 11:12 pm
Forum: Installation
Topic: [2.0] Upgrader throws exception
Replies: 8
Views: 5239

Re: [2.0] Upgrader throws exception

Looks good to me, and I agree with moving it to `serendipity_removeDeadFiles_SPL`; but I have not tested it yet.

Could actually have been a permission problem of some kind because otherwise `is_dir($dir)` should have bailed out. I'm not sure anymore. I will try to reproduce the problem.

Mattsches
by mattsches
Wed Apr 23, 2014 9:20 pm
Forum: Development
Topic: PHPUnit and Plugin Development
Replies: 4
Views: 3139

Re: PHPUnit and Plugin Development

I had some time recently and - while refactoring the typesetbuttons plugin - thought a lot about making unit testing for S9y plugin easier. Writing tests first and refactoring the plugin after made the process a lot more straightforward - because I was always certain that things still worked as expe...
by mattsches
Tue Apr 22, 2014 10:05 pm
Forum: Bugs
Topic: [2.0.0beta2] serendipity_event_typesetbuttons
Replies: 21
Views: 5631

Re: [2.0.0beta2] serendipity_event_typesetbuttons

I tried to deactivate the buttons "Enable Center Button" and "Enable Strike-through Button". But it doesn't work. They are still there when I write a new entry. Good catch, thanks, you're absolutely right. Disabled buttons should not be displayed, and this does not work correctly. Fortunately, a fi...
by mattsches
Mon Apr 21, 2014 10:03 pm
Forum: Bugs
Topic: [2.0.0beta2] serendipity_event_typesetbuttons
Replies: 21
Views: 5631

Re: [2.0.0beta2] serendipity_event_typesetbuttons

Thanks for testing this. Glad to hear everything works fine for you :) You're right, you need the latest version (from Github) of the 2k11 admin theme because - among other things - the Javascript file (serendipity.js) is very different. The number you mentioned is simply a timestamp, a little trick...
by mattsches
Sun Apr 20, 2014 11:12 am
Forum: Bugs
Topic: [2.0.0beta2] serendipity_event_typesetbuttons
Replies: 21
Views: 5631

Re: [2.0.0beta2] serendipity_event_typesetbuttons

I suppose you tested against the 2.0 branch? Did you pull in the latest changes from GitHub? This commit is crucial, otherwise it won't work.

Is there any output in the Firebug console/Chrome dev tools console? This might be a JS issue ...

Matthias
by mattsches
Sun Apr 20, 2014 11:08 am
Forum: Bugs
Topic: [2.0.0beta2] plugin already installed
Replies: 1
Views: 1200

Re: [2.0.0beta2] plugin already installed

Thanks for trying to test it. Could you please try deleting all files of the old version and copy the new one to the plugins directory? If this doesn't work, please make sure the plugin file contains a new version number (0.20). If it still doesn't work, please post the version numbers of your PHP/S...
by mattsches
Sun Apr 20, 2014 11:04 am
Forum: Development
Topic: Automated functional testing
Replies: 11
Views: 5636

Re: Automated functional testing

Hi Peter, I will definitely take a look at it. I created a setup for unit testing Serendipity plugins that works quite nicely for me. I also have some experience in functional testing with Selenium and other tools My setup also contains a small Sqlite db to create simple "fixtures" of data required ...