Page 1 of 1
Podcasting feed does not validate
Posted: Mon Dec 15, 2014 5:04 pm
by Lux
Hi!
Can you please have a look?
My podcasting feed does not validate:
Serendipity 1.7.8, Easy Podcasting Plugin 1.37.1
http://validator.w3.org/feed/check.cgi? ... index.rss2
I have no idea where the erronous lines come from.
Code: Select all
xmlns:sc="http://podlove.org/simple-chapters"
xmlns:atom="http://www.w3.org/2005/Atom">
Thanks a lot
Dirk
Re: Podcasting feed does not validate
Posted: Mon Dec 15, 2014 5:17 pm
by Lux
Re: Podcasting feed does not validate
Posted: Mon Dec 15, 2014 5:24 pm
by onli
Could you grep your blog files for "
www.w3.org/2005/Atom"?
The first mention comes from the plugin,
https://github.com/s9y/additional_plugi ... t.php#L646
The second one should not come from the core and not one from a spartacus-plugin. Maybe that line is added by your theme? Does it have a custom feed_rss2.0.tpl?
Re: Podcasting feed does not validate
Posted: Mon Dec 15, 2014 6:27 pm
by Timbalu
It looks like this
Code: Select all
....
xmlns:atom="http://www.w3.org/2005/Atom"
xmlns:sc="http://podlove.org/simple-chapters"
xmlns:atom="http://www.w3.org/2005/Atom">
which seems to be added here:
https://github.com/s9y/additional_plugi ... t.php#L652
So I would guess you have accidently added something wrong to the 'itunes_meta' (iTunes XML markup) option field.
If that check does not help. you could just have a quick test try with one of the previous plugin versions, just copy & paste.
https://github.com/s9y/additional_plugi ... t.php#L652
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 6:27 am
by Lux
Code: Select all
bundled-libs/simplepie/simplepie.inc:define('SIMPLEPIE_NAMESPACE_ATOM_10', 'http://www.w3.org/2005/Atom');
plugins/serendipity_event_flattr/serendipity_event_flattr.php: xmlns:atom="http://www.w3.org/2005/Atom"';
plugins/serendipity_event_podcast/serendipity_event_podcast.php: $eventData['display_dat'] .= " xmlns:a
plugins/serendipity_event_podcast/serendipity_event_podcast.php: $eventData['display_dat'] .= " xmlns:a
templates/default-php/feed_atom1.0.tpl: xmlns="http://www.w3.org/2005/Atom"
templates/default/feed_atom1.0.tpl: xmlns="http://www.w3.org/2005/Atom"
templates_c/2k11_fork/f4/40/a5/f440a50001731dce91c2d05597d5284026b699de.file.feed_atom1.0.tpl.php: xmlns="http://www.w
onli wrote:The second one should not come from the core and not one from a spartacus-plugin. Maybe that line is added by your theme? Does it have a custom feed_rss2.0.tpl?
I checked that, it did not come from the theme, it looks like flattr puts it in.
Currently the podcast uses a bare 2k11-Theme with an user-defined css-file.
The second problem is "podlove simple chapter".
Cheers
Dirk
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 6:36 am
by Lux
This did not work.
Cheers
Dirk
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 9:48 am
by onli
Yes, that really looks like being provided by the flattr plugin. Strange, that should've shown up by my github search as well, it is here:
https://github.com/s9y/additional_plugi ... r.php#L425
I'm not sure how to fix that properly - only one plugin can provide that line and presumably both need it. As a fix we could add that line in the flattr plugin only when the podcast plugin is not present, but that is not a nice solution.
You can fix it for your blog for now by just deleting that line or by disabling the "Add to Feed" Option in the flattr plugin.
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 11:05 am
by Lux
onli wrote:You can fix it for your blog for now by just deleting that line or by disabling the "Add to Feed" Option in the flattr plugin.
According to the error messages I see now it would be better to disable the lines in our podcast plugin.
Please check
Cheers
Dirk
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 11:59 am
by onli
The errors now are for different elements though. Yes, if the plugin is adding the description to the channel, that probably should be disabled in the plugin, as the description should be part of the themes feed_2.0.tpl.
Maybe it was assumed the second would overwrite the first, like it should be - and firefox seems to be able to do that here.
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 12:34 pm
by Lux
onli wrote:The errors now are for different elements though. Yes, if the plugin is adding the description to the channel, that probably should be disabled in the plugin, as the description should be part of the themes feed_2.0.tpl.
Maybe it was assumed the second would overwrite the first, like it should be - and firefox seems to be able to do that here.
Yes, agreed.
I did not notice the error beforehand, but maybe the upgrade of my feedreader "Tiny Tiny RSS" is a bit more strict than before.
Cheers
Dirk
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 12:51 pm
by onli
You could always try
mine ;)
I'd just delete the description addition out of the podcast plugin, though I did not look at the code already. Could take some while though till I come to that - I'd be happy if someone else beats me to fixing that.
Re: Podcasting feed does not validate
Posted: Tue Dec 16, 2014 2:15 pm
by Lux
onli wrote:You could always try
mine 
In case you support multiple users that would be an option.
onli wrote:I'd just delete the description addition out of the podcast plugin, though I did not look at the code already. Could take some while though till I come to that - I'd be happy if someone else beats me to fixing that.
Beat!
(This is currently not urgent, because we will not have new episodes the next time).
Cheers
Dirk
Re: Podcasting feed does not validate
Posted: Tue Jan 13, 2015 10:51 am
by onli
That wasn't fixed yet in Spartacus, was it?
just stumbled upon
http://blog.superfeedr.com/podcast-is-rss/ - is the plugin successful in setting all of these feed additions? First time I actually understand what is the purpose…
Re: Podcasting feed does not validate
Posted: Tue Jan 13, 2015 11:13 am
by Lux
onli wrote:That wasn't fixed yet in Spartacus, was it?
To be honest: I have no idea!
The plugin needs some love, even in case all elements are filled.
Cheers
Dirk