Page 1 of 1
Dashboard Plugin doesn't show Spam Buttons
Posted: Mon Jan 16, 2012 12:25 pm
by blog.brockha.us
The dashboard plugin shows comments to be moderated. But the buttons of the AntiSpam plugins (Ham/Spam, Valid/Spam,..) are not shown there. Neither the buttons of the standard Spam plugin nor of the Bayes plugin.
Can we do something about this?
Re: Dashboard Plugin doesn't show Spam Buttons
Posted: Mon Jan 16, 2012 12:51 pm
by Timbalu
Hmmm...
The dashboard mainly just copies the behaviour of admin/entries.inc.php or admin/comments.inc.php.
Are any Anti-Spam hooks presented in the comments or entries overviews? (I don't have any.) If they are, which plugin pushes them into, bayes? If so, it should also do for the dashbord. Please contact me in case.
Re: Dashboard Plugin doesn't show Spam Buttons
Posted: Mon Jan 16, 2012 1:02 pm
by blog.brockha.us
As far as I understand the plugin, the Bayes adds the buttons using Ajax calls. But I don't know, if it needs some special environment / event for it, we have to talk to the maintainer onli about this.
The "normal AntiSpam plugin" (with Akismet support) has buttons like that, too.
All of them are visible in the normal comment area, but not in the dashboard.
This is how the comment section looks like with two AntiSpam plugins (Akismet and Bayes):
These spam buttons are not visible in the dashboard.
Re: Dashboard Plugin doesn't show Spam Buttons
Posted: Mon Jan 16, 2012 2:02 pm
by Timbalu
Oh yes, now I know what <?php echo $comment['action_more']; ?> is for. It really was on my list to investigate....
I'll try to fit that in again... if possible.
I have to decline here, I was never in need to install any other antispam method than the default spamblock plugin. That is why I did not knew. On my linux server the SpamAssassin bayes db I always remembered as having this special format, while being a performance down buster in the manner of its working method.
Having this with php/mysql seemed me to increase this even more. And a few weeks ago I tried one of these troja downloads and was quite astonished how big it was after a few weeks of training. This is no note to discuss the well done plugin or its need for anybody out there; its just my personal 2 cents about it. Maybe this will change after having worked with it some time.
Re: Dashboard Plugin doesn't show Spam Buttons
Posted: Mon Jan 16, 2012 3:45 pm
by Timbalu
Grischa or Malte
Has this ever worked in the dashboard before, as it needs
Code: Select all
serendipity_plugin_api::hook_event('backend_comments_top', $comments);
which wasn't in there AFAIK
and a single fetch all comments at once, not like the dashboard twice (seperated calls for already approved and as to get moderated)?
The Ajax JS is designed for the normal workflow call with all comments together.
It might be some extra work to design something that fits both.
(If anybody is trying to do so via the AJAX JS for the current version, we need to keep in mind the next level I am working on, using a new (template) structure, which will need some different changes too then.
Re: Dashboard Plugin doesn't show Spam Buttons
Posted: Mon Jan 16, 2012 4:26 pm
by onli
Has this ever worked in the dashboard before
No. The hooks never were present. The buttons are included via an event-hook, only their function is via JS.