Overriding commentInfo['ip']?

Creating and modifying plugins.
Post Reply
FishNiX
Regular
Posts: 40
Joined: Sun Sep 02, 2007 6:32 pm

Overriding commentInfo['ip']?

Post by FishNiX »

Hey all -

I'm trying to write in support for X-Forwarded-For without hacking core functions. I've been trying to work with the frontend_saveComment event hook. It looks like eventData and addData come through with some information about the comment, but setting

Code: Select all

eventData['ip'] = getenv('HTTP_X_FORWARDED_FOR') != '' ? getenv('HTTP_X_FORWARDED_FOR') : $_SERVER['REMOTE_ADDR'];
or

Code: Select all

addData['ip'] = getenv('HTTP_X_FORWARDED_FOR') != '' ? getenv('HTTP_X_FORWARDED_FOR') : $_SERVER['REMOTE_ADDR'];
doesn't override commentInfo. I'm not sure if this is possible? I don't really want to hack include/functions_comments.inc.php if I don't have to since it will make upgrades, etc harder.

Thanks!
garvinhicking
Core Developer
Posts: 30022
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany
Contact:

Re: Overriding commentInfo['ip']?

Post by garvinhicking »

Hi!

Have you tried editing your serendipity_config_local.inc.php with somethin glike this:

Code: Select all

if (getenv('HTTP_X_FORWARDED_FOR') != '') {
  $_SERVER['REMOTE_ADDR'] = getenv('HTTP_X_FORWARDED_FOR');
}
then you shouldn't need to patch any code, because the proper IP you want is always contained in the right variable that everything accesses?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/
FishNiX
Regular
Posts: 40
Joined: Sun Sep 02, 2007 6:32 pm

Re: Overriding commentInfo['ip']?

Post by FishNiX »

I didn't know I could do that. I'll give it a shot.

Thanks as always!
-c
Post Reply