The Serendipity Handbook

You can now read the (german) handbook here: PDF - https://github.com/s9y/Book (LaTeX source).

Forum-Information

Before posting about errors, make sure that the answer cannot already be found in our FAQ or by searching this forum!
Posting is restricted to registered users (registering is free and simple!) due to recent spam attacks. When having trouble with this board, contact garvin(-at)s9y(-dot)org.

Board index Development mysql futures

Discussion corner for Developers of Serendipity.
User avatar
Timbalu
Regular
 
Posts: 2568
Joined: Sun May 02, 2004 3:04 pm

Postby Timbalu » Tue Apr 10, 2012 9:04 am

I have to come back to this issue.
New Mysql Server 5.5.5x versions come with InnoDB as the default storage engine, AFAIK... but Serendipity needs MyIsam, at least for things like CREATE FULLTEXT INDEX. Its not that easy to switch back in general in the my.cnf... or convert the databases or tables on the fly... So it might be good to check and note this strongly before install, wouldn't it?
Regards,
Ian

User avatar
kleinerChemiker
Regular
 
Posts: 720
Joined: Tue Oct 17, 2006 2:36 pm
Location: Vienna/Austria

Postby kleinerChemiker » Tue Apr 10, 2012 9:14 am

But MyISAM is still available? If so, then set the tables that need MyISAM to MyISAM during installation.

User avatar
Timbalu
Regular
 
Posts: 2568
Joined: Sun May 02, 2004 3:04 pm

Postby Timbalu » Tue Apr 10, 2012 9:41 am

Yes it is available.
Well, I did not ask this on my behalf, as I can do this on my own by ALTER..., script or similar, but there may be usage scenarios, where this hits users not being advanced enough to know and do this on their own? We already had some threads here claiming the fulltext index, because of this in the past.

To set MyISAM during installation sounds good - that is why I asked here. Maybe we could use the simple rule: SET storage_engine=MYISAM; and add that easily to the DB.sql...?!
Regards,
Ian

User avatar
kleinerChemiker
Regular
 
Posts: 720
Joined: Tue Oct 17, 2006 2:36 pm
Location: Vienna/Austria

Postby kleinerChemiker » Tue Apr 10, 2012 9:49 am

....and maybe a check if MyISAM is available before the installation starts. Isn't there already a check page at the beginning of the installation?

User avatar
Timbalu
Regular
 
Posts: 2568
Joined: Sun May 02, 2004 3:04 pm

Postby Timbalu » Tue Apr 10, 2012 10:04 am

This only checks if a mysql db is available and usable, not which storage engine is set, I assume.
Regards,
Ian

User avatar
kleinerChemiker
Regular
 
Posts: 720
Joined: Tue Oct 17, 2006 2:36 pm
Location: Vienna/Austria

Postby kleinerChemiker » Tue Apr 10, 2012 10:24 am

If you check this, you can also check if MyISAM is available. Better to check at the beginning than stop with an error later.

User avatar
Timbalu
Regular
 
Posts: 2568
Joined: Sun May 02, 2004 3:04 pm

Postby Timbalu » Tue Apr 10, 2012 10:51 am

That is exactly the point why I asked. :)

Maybe there were issues not to have this before, or we have it already and it doesn't work on my local environment, etc etc etc ... maybe there is no need, as hosting services always set MyISAM as default... etc... I don't know.
Regards,
Ian

User avatar
garvinhicking
Core Developer
 
Posts: 28954
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany

Postby garvinhicking » Tue Apr 10, 2012 2:37 pm

Hi!

IMHO the best idea is in MySQL layers to enable "SET .. = myisam". MyISAM is there to stay at leasts for a couple of revisions, so I don't think we need to currently go through the extra trouble of adding user options whether to use myisam or innodb, or whatever...?

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Timbalu
Regular
 
Posts: 2568
Joined: Sun May 02, 2004 3:04 pm

Postby Timbalu » Tue Apr 10, 2012 2:53 pm

Yepp, true!
Would you please do this? Having this would be great!
Regards,
Ian

User avatar
garvinhicking
Core Developer
 
Posts: 28954
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany

Postby garvinhicking » Tue Apr 10, 2012 10:38 pm

Hi!

Done. I added it to the schema_import option, which should be the only place we create tables and indexes; so the SQL statement is not sent to the server when no create statement was issued...please report any issues you might find with that approach.

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
Timbalu
Regular
 
Posts: 2568
Joined: Sun May 02, 2004 3:04 pm

Postby Timbalu » Wed Apr 11, 2012 9:40 am

works like a charm! (Even in 1.6) :D
Thank you.
Regards,
Ian



Return to Development

Who is online

Users browsing this forum: No registered users and 1 guest