The Serendipity Handbook

You can now read the (german) handbook here: PDF - https://github.com/s9y/Book (LaTeX source).

Forum-Information

Before posting about errors, make sure that the answer cannot already be found in our FAQ or by searching this forum!
Posting is restricted to registered users (registering is free and simple!) due to recent spam attacks. When having trouble with this board, contact garvin(-at)s9y(-dot)org.

Board index Plugins Double trackbacks / pingbacks and the AntiSpam plugin

Creating and modifying plugins.
User avatar
blog.brockha.us
Regular
 
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany

Postby blog.brockha.us » Thu Jan 19, 2012 10:39 pm

My S9Y saved any received pingback no matter if it was there already. As I thought this would be the case because I was testing WP pingbacks that days I fixed it for pingbacks already.

Since some days I notice that I get double trackbacks saved, too, and I was sure, that that never was the case before.

Now I noticed what's the reason of this problem: I switched off the standard anti spam plugin and exchanged it with the Bayes plugin. The standard plugin has an algorithm for denying double comments. I guess that's the reason, why I never get trackbacks saved twice coming in again.

I think this check should be part of the core, not of an anti spam plugin, because denying double trackbacks is not optional (handled by a plugin) but is nonsense always. And they are very easy to identify.

So I think, the check should be added to the core for trackbacks the same way I did that already for pingbacks.

Agree?
Last edited by blog.brockha.us on Sat Jan 21, 2012 8:04 pm, edited 1 time in total.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
garvinhicking
Core Developer
 
Posts: 29331
Joined: Tue Sep 16, 2003 9:45 pm
Location: Cologne, Germany

Postby garvinhicking » Fri Jan 20, 2012 3:23 pm

Hi!

Sounds good to me; trackbacks are identified by their target URL, not their subject/body, right?

So for me +1 to go ahead :)

Regards,
Garvin
# Garvin Hicking (s9y Developer)
# Did I help you? Consider making me happy: http://wishes.garv.in/
# or use my PayPal account "paypal {at} supergarv (dot) de"
# My "other" hobby: http://flickr.garv.in/

User avatar
blog.brockha.us
Regular
 
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany

Postby blog.brockha.us » Sat Jan 21, 2012 8:04 pm

Yes, the same way as pingbacks are (url -> article id). So they are easily detected as dupes.
Okay. I will do a patch for this. :)
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/

User avatar
blog.brockha.us
Regular
 
Posts: 695
Joined: Tue Jul 03, 2007 3:34 am
Location: Berlin, Germany

Postby blog.brockha.us » Wed Jan 25, 2012 2:47 pm

Patched Serenditpity 1.6(.1) and 1.7 on GitHub.
- Grischa Brockhaus - http://blog.brockha.us
- Want to make me happy? http://wishes.brockha.us/



Return to Plugins

Who is online

Users browsing this forum: No registered users and 2 guests