[2.0.0beta2] Media button in Non-WYSIWYMG Editor

Found a bug? Tell us!!
Post Reply
u1amo01
Regular
Posts: 273
Joined: Fri Sep 28, 2007 3:55 pm
Location: Kurpfalz, Germany
Contact:

[2.0.0beta2] Media button in Non-WYSIWYMG Editor

Post by u1amo01 »

Sorry, I don't know the correct name for this editor, I allways just click "no" at user settings "Use WYSIWYG editor?"

There's something strange with the button "Media" if I want to create a entry with more than one pic which should be links.

Here is what I do:
I click on Media
choose a pic
change button from "I want to display it as an image" to "I want to display it as a link to this url:"

It's fine the first time. For the second pic the button is already active for ""I want to display it as a link to this url:" but it looks like the system doesn't regognize this. I get code without link.

Code: Select all

<a class="serendipity_image_link" title="s9y_beta_dash.jpg" href='/blog/uploads/screenshots/s9y_beta_dash.jpg'><!-- s9ymdb: --><img class="serendipity_image_left" width="250" height="174"  src="/blog/uploads/screenshots/s9y_beta_dash.serendipityThumb.jpg" title="s9y_beta_dash.jpg" alt=""></a>

<!-- s9ymdb: --><img class="serendipity_image_left" width="250" height="142"  src="/blog/uploads/screenshots/s9y_178_b.serendipityThumb.jpg"  alt="">
As workaround I can activate "I want to display it as a image" and click on "Done". Of course this inserts a pic without link. When I insert another pic and change the button again from "I want to display it as an image" to "I want to display it as a link to this url:" I get correct code.

This happens with Firefox 28.0, Opera 20.0.1387.91. Not with IE 9, because when I click on "Done" not only the media lib window gets closed but the whole browser. Funny easteregg ;-)

BTW, when we talk about the buttons in the Non-WYSIWYG-Editor: could you please change the capital i on button for em to a small i? The capital letter i in italic looks like a slash. Very confusing.
yellowled
Regular
Posts: 7111
Joined: Fri Jan 13, 2006 11:46 am
Location: Eutin, Germany
Contact:

Re: [2.0.0beta2] Media button in Non-WYSIWYMG Editor

Post by yellowled »

u1amo01 wrote:This happens with Firefox 28.0, Opera 20.0.1387.91. Not with IE 9, because when I click on "Done" not only the media lib window gets closed but the whole browser.
Confirmed in Chrome. Smells like something doesn't get reset properly, maybe cookies if they're involved here (don't know).
u1amo01 wrote:BTW, when we talk about the buttons in the Non-WYSIWYG-Editor: could you please change the capital i on button for em to a small i? The capital letter i in italic looks like a slash. Very confusing.
I would've never interpreted that as a slash, but you're right. I might look confusing.

YL
thh
Regular
Posts: 419
Joined: Thu Oct 26, 2006 2:38 pm
Location: Stuttgart, Germany
Contact:

Re: [2.0.0beta2] Media button in Non-WYSIWYMG Editor

Post by thh »

yellowled wrote:
u1amo01 wrote:This happens with Firefox 28.0, Opera 20.0.1387.91. Not with IE 9, because when I click on "Done" not only the media lib window gets closed but the whole browser.
Confirmed in Chrome. Smells like something doesn't get reset properly, maybe cookies if they're involved here (don't know).
In 2.0-beta3, that still doesn't work completely; it will pick up changes in the setting of "no link / add link to ..." (in German: "Das Bild soll kein Link sein" / "Das Bild soll hierhin linken: ...") only the second time you change the setting. All other settings can now correctly be changed.

Steps to reproduce:
  1. Use the media button ("Mediendatenbank") in the non-WYSIWYG editor to add a picture.
    Select "preview" ("Ich möchte die Vorschau im Eintrag haben."), center alignment and a link to the larger picture ("Das Bild soll hierhin linken: ...).
  2. S9y will insert the necessary code, according to your settings.
  3. Use the media button ("Mediendatenbank") in the non-WYSIWYG editor to add another picture.
    This time, change all three settings. Select "large image" ("Ich möchte das große Bild im Eintrag haben."), left aligned and no link ("Das Bild soll kein Link sein").
  4. S9y will insert the necessary code and change the first two settings, but not the third: you'll get the large picture, left aligned, but with a link
  5. Use the media button again to insert the same picture. Do not change any setting; you'll see that your last choices - even concerning "no link" - have been saved.
  6. This time, s9y will honor all settings: you'll get the large picture, left aligned, and no link
You can switcht that back and forth as you like; changes to picture size (preview / large picture) and alignment will be picked up immediately, changes to link/no link will always need to tries.

Tested on Firefox 31.0.

Is there an issuee I that could be reopened? If not, I'll submit a new one.
Last edited by thh on Tue Aug 26, 2014 1:10 pm, edited 2 times in total.
Timbalu
Regular
Posts: 4598
Joined: Sun May 02, 2004 3:04 pm

Re: [2.0.0beta2] Media button in Non-WYSIWYMG Editor

Post by Timbalu »

Yeah, now I remember I had that on Weekend too, but I thought I had made a mistake, since another click brought the expected result.

I just tested again. Confirmed, even with CKE.

We had something similar in #143, not linking an image. I'd say open a new issue and reference it to #143.
Regards,
Ian

Serendipity Styx Edition and additional_plugins @ https://ophian.github.io/ @ https://github.com/ophian
thh
Regular
Posts: 419
Joined: Thu Oct 26, 2006 2:38 pm
Location: Stuttgart, Germany
Contact:

Re: [2.0.0beta2] Media button in Non-WYSIWYMG Editor

Post by thh »

Timbalu wrote:I just tested again. Confirmed, even with CKE.

We had something similar in #143, not linking an image. I'd say open a new issue and reference it to #143.
Thanks.

https://github.com/s9y/Serendipity/issues/207

It seems the setting is cached, but wrongly; if you switch the setting back and forth, you will always get the result of your last setting.

Set "link" (first time) = get "link".
Set it to "no link" = get "link", again
Switch back to "link" = get "no link" (!)
Switch to "no link" again = get "link" and so on

It doesn't matter if you use the same image or other images, and it doesn't matter if you edit (or create) the same entry or multiple entries.
Post Reply