Tag plugin doesn't work correctly with slash in tag name

WebComPas · Post by **WebComPas** » Thu Dec 18, 2008 3:21 pm

Hallo!

I'm using the sidebar tag plugin. There is a tag called "Extension/Plugin". Of course the link to this tag in the sidebar plugin doesn't work correctly, because of the "/" in the tag name.
I suggest to add an option to the plugin configuration area to set up a user-defined character which will replace the "/" in the URL, that also those tags will work.

I hope, this will be fixed soon. Thanks!

Regards,
Pascal

judebert · Post by **judebert** » Mon Dec 22, 2008 8:34 pm

I made the change you requested, but since I don't use the freetag plugin, I can't test it.

Please download http://judebert.com/progress/media/s9y/ ... reetag.zip and test it it out. If there are no problems, I'll add it to the repository.

WebComPas · Post by **WebComPas** » Mon Dec 22, 2008 9:07 pm

Thanks a lot. I tried tested just it, but the problem doesn't seem to be solved. Now the tag with the slash doesn't appear anymore. In the entry footer the link still contains the slash.

It would be great if you could fix these problems.

Regards,
Pascal

judebert · Post by **judebert** » Tue Dec 23, 2008 4:43 pm

I didn't even realize there was a tag in the footer. And of course, that one's busted too, isn't it?

Okay, I've made another shot at it. Rather than letting you replace slash with whatever you want, I've just replaced it with a special character. The same thing was already being done for periods.

You can download it at the same place: http://judebert.com/progress/media/s9y/plugins. Let me know if it works.

WebComPas · Post by **WebComPas** » Tue Dec 23, 2008 5:37 pm

Unfortunately it still doesn't work correctly. Now the link in the entry footer has changed, but still doesn't work. The slash now is replaced by "\0". When I click on it, the page for entries with this tag appears, but the it looks for entries with the Tag "Extention\\0Plugin". Of course none will be found.

Furthermore the sidebar link for this tag still is missing.

judebert · Post by **judebert** » Tue Dec 23, 2008 7:50 pm

Darn it. Rather than wasting your time while I figure out my PHP and HTTP escapes, I installed the freetag plugin on my sandbox and fiddled with it.

The newest iteration allows tags with slashes and works just fine on my sandbox.

The only anomaly is that the browser's URL line may present an odd character. But the functionality is correct, and the tag page displays the slash, as intended.

Try it again and let me know.

WebComPas · Post by **WebComPas** » Tue Dec 30, 2008 4:08 pm

Up to now I've only found one problem. The tag page is displayed for the tag "ExtensionPlugin" instead of "Extension/Plugin" and therefore there no matching entry is shown.
Apart from that it seems to work correctly.

judebert · Post by **judebert** » Tue Jan 20, 2009 4:56 pm

Odd. Mine tries to load http://tpl.judebert.com/serendipity/plu ... extensions, so the URL looks really odd. But it shows the tagged entry.

Perhaps the problem is that I provided an invalid link. My modifications to the plugin are actually at http://judebert.com/progress/media/s9y/ ... reetag.zip. Please see if that version works. If so, I'll update the plugin in SPARTACUS.

WebComPas · Post by **WebComPas** » Wed Jan 28, 2009 10:15 pm

I've tried the mentioned version of the plugin, but the problem I mentioned in my last post still occurs.

judebert · Post by **judebert** » Wed Jan 28, 2009 10:44 pm

Where are you seeing this behavior? In my template site, it works as expected when clicking on the link at the bottom of the entry. Is it being linked differently elsewhere?

WebComPas · Post by **WebComPas** » Wed Jan 28, 2009 11:14 pm

When I click the link in the entry footer oder in the sidebar, the problem occurs. The page is being displayed, but insteat of "Extension/Plugin" the tag is named "ExtensionPlugin" And because there are no entries with the last one no entries are displayed.

judebert · Post by **judebert** » Thu Jan 29, 2009 3:07 pm

Okay, I've updated again. The new plugin, version 3.1, can be found at http://judebert.com/progress/media/s9y/ ... reetag.zip. Unzip it, replace the existing serendipity_event_freetag.php with the one from the archive, verify that the version in your plugin configuration is 3.1, and let me know if it works.

WebComPas · Post by **WebComPas** » Sun Feb 01, 2009 2:04 pm

I'm sorry but the problem still exists. As you said, I also checked that the plugin version is 3.1.

Regards,
Pascal

judebert · Post by **judebert** » Mon Feb 02, 2009 6:42 pm

Hmm. I wonder why it's working for me and not for you. I'll look at it some more and see what I can come up with.

judebert · Post by **judebert** » Tue Feb 10, 2009 11:30 pm

For the life of me, I can't figure out why this isn't working. You can see it working on my sandbox, http://tpl.judebert.com/serendipity/plu ... extensions. (I'm assuming it does work for you on my sandbox! If not, perhaps there's a browser issue, and I'll have to code a different solution.)

Perhaps you loaded up a cached version? I'm really at a loss, and I'd appreciate any help anyone could provide.

Tag plugin doesn't work correctly with slash in tag name

Tag plugin doesn't work correctly with slash in tag name

Re: Tag plugin doesn't work correctly with slash in tag name

Re: Tag plugin doesn't work correctly with slash in tag name