Timbalu wrote:btw, what is the exact difference between
- Code: Select all
<option value="pending">Zu bewilligende/pending</option>
<option value="confirm">Zu bestätigende/confirm</option>
in filters??
Does that come from bayes?
No, it resides in comments.inc.php and lang constants COMMENTS_FILTER_NEED_APPROVAL and COMMENTS_FILTER_NEED_CONFIRM.
This questions somehow is still active, as I can't really see what is meant.
For me it looks like, as if it is some old Serendipity code change from 'confirm' to 'pending' or vice versa and the code still is there to support users having both status entries in their comments table. (Is this possible?)
- Code: Select all
...
} elseif ($serendipity['GET']['filter']['show'] == 'pending') {
$and .= "AND status = 'pending'";
$searchString .= "&serendipity[filter][show]=pending";
} elseif ($serendipity['GET']['filter']['show'] == 'confirm') {
$and .= "AND status LIKE 'confirm%'";
$searchString .= "&serendipity[filter][show]=confirm";
...
forcing comment show request actions to
- Code: Select all
WHERE c.id = " . (int)$serendipity['GET']['id'] ." AND (status = 'pending' OR status LIKE 'confirm%')";
Now..., if that really is an ancient relict from Serendipity's child ages, should'nt we clean it up and get rid of 'confirm'?
